Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: lib/src/runner/load_suite.dart

Issue 1239693002: Pass actual TestPlatform and OperatingSystem values to Suite. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Update pubspec. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/browser/server.dart ('k') | lib/src/runner/loader.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/load_suite.dart
diff --git a/lib/src/runner/load_suite.dart b/lib/src/runner/load_suite.dart
index 919aa88c69d3c62d985707f2bb443e66dfd3950a..e8d5abc7a65d061a758298b2c0fbfdaaa8e62808 100644
--- a/lib/src/runner/load_suite.dart
+++ b/lib/src/runner/load_suite.dart
@@ -12,6 +12,7 @@ import '../../test.dart';
import '../backend/invoker.dart';
import '../backend/metadata.dart';
import '../backend/suite.dart';
+import '../backend/test_platform.dart';
import '../utils.dart';
import 'load_exception.dart';
@@ -45,7 +46,7 @@ class LoadSuite extends Suite {
///
/// If the the load test is closed before [body] is complete, it will close
/// the suite returned by [body] once it completes.
- factory LoadSuite(String name, body(), {String platform}) {
+ factory LoadSuite(String name, body(), {TestPlatform platform}) {
var completer = new Completer.sync();
return new LoadSuite._(name, () {
var invoker = Invoker.current;
@@ -83,7 +84,7 @@ class LoadSuite extends Suite {
///
/// The suite's name will be based on [exception]'s path.
factory LoadSuite.forLoadException(LoadException exception,
- {StackTrace stackTrace, String platform}) {
+ {StackTrace stackTrace, TestPlatform platform}) {
if (stackTrace == null) stackTrace = new Trace.current();
return new LoadSuite("loading ${exception.path}", () {
@@ -97,7 +98,7 @@ class LoadSuite extends Suite {
platform: suite.platform);
}
- LoadSuite._(String name, void body(), this.suite, {String platform})
+ LoadSuite._(String name, void body(), this.suite, {TestPlatform platform})
: super([
new LocalTest(name,
new Metadata(timeout: new Timeout(new Duration(minutes: 5))),
@@ -112,7 +113,7 @@ class LoadSuite extends Suite {
/// transforms [suite] once it's loaded.
///
/// If [suite] completes to `null`, [change] won't be run.
- Suite changeSuite(Suite change(Suite suite)) {
+ LoadSuite changeSuite(Suite change(Suite suite)) {
return new LoadSuite._changeSuite(this, suite.then((loadedSuite) {
if (loadedSuite == null) return null;
return change(loadedSuite);
« no previous file with comments | « lib/src/runner/browser/server.dart ('k') | lib/src/runner/loader.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698