Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: lib/src/runner/browser/browser_manager.dart

Issue 1239693002: Pass actual TestPlatform and OperatingSystem values to Suite. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Update pubspec. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « lib/src/backend/suite.dart ('k') | lib/src/runner/browser/iframe_listener.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library test.runner.browser.browser_manager; 5 library test.runner.browser.browser_manager;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:convert'; 8 import 'dart:convert';
9 9
10 import 'package:http_parser/http_parser.dart'; 10 import 'package:http_parser/http_parser.dart';
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 await new Future.error( 132 await new Future.error(
133 new LoadException(path, asyncError.error), 133 new LoadException(path, asyncError.error),
134 asyncError.stackTrace); 134 asyncError.stackTrace);
135 } 135 }
136 136
137 return new Suite(response["tests"].map((test) { 137 return new Suite(response["tests"].map((test) {
138 var testMetadata = new Metadata.deserialize(test['metadata']); 138 var testMetadata = new Metadata.deserialize(test['metadata']);
139 var testChannel = suiteChannel.virtualChannel(test['channel']); 139 var testChannel = suiteChannel.virtualChannel(test['channel']);
140 return new IframeTest(test['name'], testMetadata, testChannel, 140 return new IframeTest(test['name'], testMetadata, testChannel,
141 mapper: mapper); 141 mapper: mapper);
142 }), metadata: metadata, path: path, onClose: () => closeIframe()); 142 }), platform: browser, metadata: metadata, path: path,
143 onClose: () => closeIframe());
143 } 144 }
144 } 145 }
OLDNEW
« no previous file with comments | « lib/src/backend/suite.dart ('k') | lib/src/runner/browser/iframe_listener.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698