Remove some legacy versions of StartsWith and EndsWith.

Remove some legacy versions of StartsWith and EndsWith.

This just replaces
  true -> base::CompareCase::SENSITIVE
  false -> base::CompareCase::INSENSITIVE_ASCII

I checked the insensitive cases to make sure they're not doing anything suspicious. The old version is a sometimes-correct Unicode comparison so converting to INSENSTITIVE_ASCII isn't a no-op. However, generally the prefix/suffix checking is done against a hardcoded string so there were very few cases to actually look at.

extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc has a not-quite search-and-replace change where I changed the type of a class variable.

BUG=506255
TBR=jam

Committed: https://crrev.com/edce9a33027cc5f73c4866d70e34f690f6720a56
Cr-Commit-Position: refs/heads/master@{#338996}

[brettw, 2015-07-15 18:32:11]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-15 18:35:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1239493005/1

[commit-bot: I haz the power, 2015-07-15 18:57:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-15 18:57:28]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

(exceeded global retry quota)

[brettw, 2015-07-15 19:18:12]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-15 19:22:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1239493005/20001

[brettw, 2015-07-15 19:27:20]

brettw@chromium.org changed reviewers:
+ jam@chromium.org

[commit-bot: I haz the power, 2015-07-15 19:52:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-15 19:52:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

(exceeded global retry quota)

[brettw, 2015-07-15 20:51:47]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-15 20:53:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1239493005/40001

[commit-bot: I haz the power, 2015-07-15 21:31:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-15 21:31:53]

Dry run: Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_andr...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

(exceeded global retry quota)

[brettw, 2015-07-15 21:56:02]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-15 21:57:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1239493005/60001

[commit-bot: I haz the power, 2015-07-15 22:19:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-15 22:19:18]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

(exceeded global retry quota)

[brettw, 2015-07-15 22:38:41]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-07-15 22:39:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1239493005/60001

[commit-bot: I haz the power, 2015-07-15 22:39:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-15 22:40:01]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[brettw, 2015-07-16 03:12:51]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-07-16 03:13:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1239493005/60001

[jam, 2015-07-16 03:28:52]

lgtm

https://codereview.chromium.org/1239493005/diff/60001/dbus/string_util.cc
File dbus/string_util.cc (right):

https://codereview.chromium.org/1239493005/diff/60001/dbus/string_util.cc#new...
dbus/string_util.cc:17: if (!base::StartsWith(value, "/", kCaseSensitive))
seems like there's no more need for the local kCaseSensitive variable

[commit-bot: I haz the power, 2015-07-16 03:55:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-16 03:55:22]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[brettw, 2015-07-16 05:09:02]

https://codereview.chromium.org/1239493005/diff/60001/dbus/string_util.cc
File dbus/string_util.cc (right):

https://codereview.chromium.org/1239493005/diff/60001/dbus/string_util.cc#new...
dbus/string_util.cc:17: if (!base::StartsWith(value, "/", kCaseSensitive))
Good idea, done.

[brettw, 2015-07-16 05:09:10]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-07-16 05:09:11]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1239493005/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-07-16 05:09:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1239493005/80001

[commit-bot: I haz the power, 2015-07-16 05:12:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-16 05:12:36]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

(exceeded global retry quota)

[brettw, 2015-07-16 05:31:07]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-07-16 05:31:07]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1239493005/#ps100001
(title: "merge")

[commit-bot: I haz the power, 2015-07-16 05:31:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1239493005/100001

[commit-bot: I haz the power, 2015-07-16 06:48:19]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-07-16 06:49:12]

Patchset 6 (id:??) landed as
https://crrev.com/edce9a33027cc5f73c4866d70e34f690f6720a56
Cr-Commit-Position: refs/heads/master@{#338996}

[yosin_UTC9, 2015-07-16 07:09:20]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1233453011/ by yosin@chromium.org.

The reason for reverting is: Compilation error on Windows:

FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc
"C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo
/showIncludes /FC @obj\chrome\installer\gcapi\gcapi_lib.gcapi.obj.rsp /c
..\..\chrome\installer\gcapi\gcapi.cc
/Foobj\chrome\installer\gcapi\gcapi_lib.gcapi.obj /Fdobj\chrome\gcapi_lib.cc.pdb

c:\b\build\slave\win-latest-rel\build\src\chrome\installer\gcapi\gcapi.cc(365) :
error C3083: 'StartsWith': the symbol to the left of a '::' must be a type
c:\b\build\slave\win-latest-rel\build\src\chrome\installer\gcapi\gcapi.cc(365) :
error C2039: 'INSENSITIVE_ASCII' : is not a member of 'base'
c:\b\build\slave\win-latest-rel\build\src\chrome\installer\gcapi\gcapi.cc(365) :
error C2065: 'INSENSITIVE_ASCII' : undeclared identifier
ninja: build stopped: subcommand failed.
.

[yosin_UTC9, 2015-07-16 07:20:37]

yosin@chromium.org changed reviewers:
+ yosin@chromium.org

[yosin_UTC9, 2015-07-16 07:20:39]

https://codereview.chromium.org/1239493005/diff/100001/chrome/installer/gcapi...
File chrome/installer/gcapi/gcapi.cc (right):

https://codereview.chromium.org/1239493005/diff/100001/chrome/installer/gcapi...
chrome/installer/gcapi/gcapi.cc:365: base::StartsWith::INSENSITIVE_ASCII) &&
Should be |base::CompareCase::INSENSITIVE_ASCII|.

Not sure why some win bots compiled this successfully.