Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: net/http/http_network_transaction.cc

Issue 1239493005: Remove some legacy versions of StartsWith and EndsWith. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_network_transaction.cc
diff --git a/net/http/http_network_transaction.cc b/net/http/http_network_transaction.cc
index 76e352eed923aaabcb6d8011f253cd02629acf2a..7fe07c6c16bc6801f9fd5118528188fff480bef2 100644
--- a/net/http/http_network_transaction.cc
+++ b/net/http/http_network_transaction.cc
@@ -1444,7 +1444,8 @@ void HttpNetworkTransaction::RecordSSLFallbackMetrics(int result) {
return;
const std::string& host = request_->url.host();
- bool is_google = base::EndsWith(host, "google.com", true) &&
+ bool is_google = base::EndsWith(host, "google.com",
+ base::CompareCase::SENSITIVE) &&
(host.size() == 10 || host[host.size() - 11] == '.');
if (is_google) {
// Some fraction of successful connections use the fallback, but only due to

Powered by Google App Engine
This is Rietveld 408576698