components/omnibox/browser/keyword_provider.cc - Issue 1239493005: Remove some legacy versions of StartsWith and EndsWith.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/keyword_provider.cc

Issue 1239493005: Remove some legacy versions of StartsWith and EndsWith. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/installer/gcapi/gcapi.cc ('K') | « components/google/core/browser/google_util.cc ('k') | components/omnibox/browser/search_suggestion_parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/omnibox/browser/keyword_provider.cc

diff --git a/components/omnibox/browser/keyword_provider.cc b/components/omnibox/browser/keyword_provider.cc

index b6f7877b3e30c00752b82e7d30b25e556b0ed3e5..8992f02f8717f4d795f9b93b76d03ee8866442e9 100644

--- a/components/omnibox/browser/keyword_provider.cc

+++ b/components/omnibox/browser/keyword_provider.cc

@@ -139,7 +139,8 @@ const TemplateURL* KeywordProvider::GetSubstitutingTemplateURLForInput(

// of the original input.

if (input->cursor_position() != base::string16::npos &&

!remaining_input.empty() &&

- base::EndsWith(input->text(), remaining_input, true)) {

+ base::EndsWith(input->text(), remaining_input,

+ base::CompareCase::SENSITIVE)) {

int offset = input->text().length() - input->cursor_position();

// The cursor should never be past the last character or before the

// first character.

« chrome/installer/gcapi/gcapi.cc ('K') | « components/google/core/browser/google_util.cc ('k') | components/omnibox/browser/search_suggestion_parser.cc » ('j') | no next file with comments »