chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc - Issue 1239493005: Remove some legacy versions of StartsWith and EndsWith.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

Issue 1239493005: Remove some legacy versions of StartsWith and EndsWith. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/cld_component_installer_unittest.cc ('k') | chrome/browser/extensions/default_apps.cc » ('j') | chrome/installer/gcapi/gcapi.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

index 169f8da2b04d6e32a15ab6fd9a6c1b20467985a8..0f58e84b04689dde5ffe465ffe8d882707b726d4 100644

--- a/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

@@ -223,7 +223,8 @@ class DelayLoadStartAndExecuteJavascript

const GURL& url,

ui::PageTransition transition_type) override {

if (script_was_executed_ &&

- base::EndsWith(url.spec(), until_url_suffix_, true)) {

+ base::EndsWith(url.spec(), until_url_suffix_,

+ base::CompareCase::SENSITIVE)) {

content::WebContentsObserver::Observe(NULL);

test_navigation_listener_->ResumeAll();

}