Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: third_party/zlib/google/zip_reader.cc

Issue 1239493005: Remove some legacy versions of StartsWith and EndsWith. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/zlib/google/zip_reader.cc
diff --git a/third_party/zlib/google/zip_reader.cc b/third_party/zlib/google/zip_reader.cc
index d3c2775844a5ddb1dc687c8d72c2cac17b449bca..e0871c85367321c785c31383f8cf8d2a28000027 100644
--- a/third_party/zlib/google/zip_reader.cc
+++ b/third_party/zlib/google/zip_reader.cc
@@ -131,7 +131,8 @@ ZipReader::EntryInfo::EntryInfo(const std::string& file_name_in_zip,
original_size_ = raw_file_info.uncompressed_size;
// Directory entries in zip files end with "/".
- is_directory_ = base::EndsWith(file_name_in_zip, "/", false);
+ is_directory_ = base::EndsWith(file_name_in_zip, "/",
+ base::CompareCase::INSENSITIVE_ASCII);
// Check the file name here for directory traversal issues.
is_unsafe_ = file_path_.ReferencesParent();

Powered by Google App Engine
This is Rietveld 408576698