components/omnibox/browser/search_suggestion_parser.cc - Issue 1239493005: Remove some legacy versions of StartsWith and EndsWith.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/search_suggestion_parser.cc

Issue 1239493005: Remove some legacy versions of StartsWith and EndsWith. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/installer/gcapi/gcapi.cc ('K') | « components/omnibox/browser/keyword_provider.cc ('k') | components/pairing/bluetooth_controller_pairing_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/omnibox/browser/search_suggestion_parser.cc

diff --git a/components/omnibox/browser/search_suggestion_parser.cc b/components/omnibox/browser/search_suggestion_parser.cc

index 11fbdbbbc22c353b735d641f13454a499034211c..30543fc3dbbc3f658ae1ff47ab2aec21b245c1f4 100644

--- a/components/omnibox/browser/search_suggestion_parser.cc

+++ b/components/omnibox/browser/search_suggestion_parser.cc

@@ -151,7 +151,8 @@ void SearchSuggestionParser::SuggestResult::ClassifyMatchContents(

// contents, and the input text has an overlap with contents.

if (base::StartsWith(suggestion_, input_text,

base::CompareCase::SENSITIVE) &&

- base::EndsWith(suggestion_, match_contents_, true) &&

+ base::EndsWith(suggestion_, match_contents_,

+ base::CompareCase::SENSITIVE) &&

(input_text.length() > contents_index)) {

lookup_text = input_text.substr(contents_index);

}