Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: tools/gn/ninja_binary_target_writer.cc

Issue 1239493005: Remove some legacy versions of StartsWith and EndsWith. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/ninja_binary_target_writer.cc
diff --git a/tools/gn/ninja_binary_target_writer.cc b/tools/gn/ninja_binary_target_writer.cc
index 1fc06b26e5787debef792f70a551dabd259ee22c..971f4d87f439bbb3ff4941a263a0603069dab438 100644
--- a/tools/gn/ninja_binary_target_writer.cc
+++ b/tools/gn/ninja_binary_target_writer.cc
@@ -650,7 +650,8 @@ void NinjaBinaryTargetWriter::WriteLibs() {
const std::string framework_ending(".framework");
for (size_t i = 0; i < all_libs.size(); i++) {
if (settings_->IsMac() &&
- base::EndsWith(all_libs[i], framework_ending, false)) {
+ base::EndsWith(all_libs[i], framework_ending,
+ base::CompareCase::INSENSITIVE_ASCII)) {
// Special-case libraries ending in ".framework" on Mac. Add the
// -framework switch and don't add the extension to the output.
out_ << " -framework ";

Powered by Google App Engine
This is Rietveld 408576698