Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1237383004: Revert of Implement suspend() and resume() for OfflineAudioContext (Closed)

Created:
5 years, 5 months ago by hongchan
Modified:
5 years, 5 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Implement suspend() and resume() for OfflineAudioContext (patchset #25 id:910001 of https://codereview.chromium.org/1140723003/) Reason for revert: Leak detected. (numberOfLiveActiveDOMObjects is non-zero) Original issue's description: > Adds suspend() and resume() feature in OfflineAudioContext to support the > synchronous graph manipulation with the render block precision (k-rate) in the > non-realtime audio rendering. > > The benefit of being able to suspend/resume the context with the render block > precision is: > > 1) The audio graph can be modified in a time-accurate way, independent of the > hardware. Without this, setTimeout, completion events, or state change events > are needed to manipulate the graph, and the results depend on when the events > are fired and on how fast the hardware is. > > 2) Makes an OfflineAudioContext more symmetrical to the AudioContext, which > already supports suspend/resume. (There are minor difference required by the > difference between offline and online contexts.) > > This feature also can be used in Blink layout tests to verify the behavior of > audio rendering. With this feature in the implementation, several flaky web > audio layout tests can be fixed. > > # Editor's draft spec PR: > http://webaudio.github.io/web-audio-api/#the-offlineaudiocontext-interface > > # Web Audio API issue tracker entry: > https://github.com/WebAudio/web-audio-api/issues/302#issuecomment-106101885 > > > BUG=497933 > TEST= > webaudio/offlineaudiocontext-suspend-resume-basic.html > webaudio/offlineaudiocontext-suspend-resume-eventhandler.html > webaudio/offlineaudiocontext-suspend-resume-graph-manipulation.html > webaudio/offlineaudiocontext-suspend-resume-promise.html > webaudio/offlineaudiocontext-suspend-resume-sequence.html > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199129 TBR=haraken@chromium.org,oilpan-reviews@chromium.org,rtoy@chromium.org,yhirano@chromium.org,tkent@chromium.org,hiroshige@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=497933 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199136

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -1140 lines) Patch
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/webaudio/audiocontext-suspend-resume.html View 2 chunks +111 lines, -27 lines 0 comments Download
M LayoutTests/webaudio/audiocontext-suspend-resume-expected.txt View 1 chunk +14 lines, -7 lines 0 comments Download
D LayoutTests/webaudio/offlineaudiocontext-suspend-resume-basic.html View 1 chunk +0 lines, -99 lines 0 comments Download
D LayoutTests/webaudio/offlineaudiocontext-suspend-resume-basic-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/webaudio/offlineaudiocontext-suspend-resume-eventhandler.html View 1 chunk +0 lines, -67 lines 0 comments Download
D LayoutTests/webaudio/offlineaudiocontext-suspend-resume-eventhandler-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/webaudio/offlineaudiocontext-suspend-resume-graph-manipulation.html View 1 chunk +0 lines, -84 lines 0 comments Download
D LayoutTests/webaudio/offlineaudiocontext-suspend-resume-graph-manipulation-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/webaudio/offlineaudiocontext-suspend-resume-promise.html View 1 chunk +0 lines, -58 lines 0 comments Download
D LayoutTests/webaudio/offlineaudiocontext-suspend-resume-promise-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/webaudio/offlineaudiocontext-suspend-resume-sequence.html View 1 chunk +0 lines, -74 lines 0 comments Download
D LayoutTests/webaudio/offlineaudiocontext-suspend-resume-sequence-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
M LayoutTests/webaudio/resources/audio-testing.js View 2 chunks +2 lines, -31 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/modules/webaudio/AbstractAudioContext.h View 5 chunks +5 lines, -14 lines 0 comments Download
M Source/modules/webaudio/AbstractAudioContext.cpp View 3 chunks +34 lines, -38 lines 0 comments Download
M Source/modules/webaudio/AudioContext.h View 1 chunk +2 lines, -5 lines 0 comments Download
M Source/modules/webaudio/AudioContext.cpp View 3 chunks +24 lines, -33 lines 0 comments Download
M Source/modules/webaudio/AudioNode.h View 2 chunks +13 lines, -13 lines 0 comments Download
M Source/modules/webaudio/AudioNode.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webaudio/DeferredTaskHandler.h View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/modules/webaudio/DeferredTaskHandler.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/modules/webaudio/OfflineAudioContext.h View 2 chunks +1 line, -90 lines 0 comments Download
M Source/modules/webaudio/OfflineAudioContext.cpp View 5 chunks +16 lines, -288 lines 0 comments Download
M Source/modules/webaudio/OfflineAudioContext.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/modules/webaudio/OfflineAudioDestinationNode.h View 4 chunks +5 lines, -27 lines 0 comments Download
M Source/modules/webaudio/OfflineAudioDestinationNode.cpp View 5 chunks +20 lines, -74 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hongchan
Created Revert of Implement suspend() and resume() for OfflineAudioContext
5 years, 5 months ago (2015-07-17 21:55:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237383004/1
5 years, 5 months ago (2015-07-17 21:56:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=199136
5 years, 5 months ago (2015-07-17 21:57:35 UTC) #3
haraken
5 years, 5 months ago (2015-07-18 01:14:29 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698