Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 123503002: Mark the AtomicString(const String&) constructor as explicit (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
Reviewers:
eseidel
CC:
blink-reviews, adamk+blink_chromium.org, krit, loislo+blink_chromium.org, zoltan1, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, abarth-chromium, kinuko, yurys+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, gavinp+loader_chromium.org, jchaffraix+rendering, darktears, pdr, f(malita), Stephen Chennney, Nate Chapin, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Mark the AtomicString(const String&) constructor as explicit Mark the AtomicString(const String&) constructor as explicit to avoid implicit conversion from String to StringImpl. Such conversion can be expensive when the String's internal StringImpl is not already atomic. Therefore, I believe it is a good idea to make this conversion explicit and avoid it when possible (i.e. construct directly an AtomicString if we know we are going to need an AtomicString). BUG=323739 R=eseidel Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164608

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -22 lines) Patch
M Source/core/css/resolver/StyleBuilderConverter.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fileapi/FileReaderLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameView.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Location.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FormSubmission.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/ClipPathOperation.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGAElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/xml/XPathFunctions.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/text/AtomicString.h View 1 2 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Inactive
6 years, 11 months ago (2014-01-02 22:12:23 UTC) #1
Inactive
I rebased the patch.
6 years, 11 months ago (2014-01-05 21:53:50 UTC) #2
Inactive
Eric, any objection?
6 years, 11 months ago (2014-01-07 20:11:15 UTC) #3
eseidel
lgtm
6 years, 11 months ago (2014-01-07 20:15:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/123503002/80001
6 years, 11 months ago (2014-01-07 20:15:56 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 20:23:03 UTC) #6
Message was sent while issue was closed.
Change committed as 164608

Powered by Google App Engine
This is Rietveld 408576698