|
Mark the AtomicString(const String&) constructor as explicit
Mark the AtomicString(const String&) constructor as explicit to avoid implicit
conversion from String to StringImpl. Such conversion can be expensive when the
String's internal StringImpl is not already atomic. Therefore, I believe it is
a good idea to make this conversion explicit and avoid it when possible (i.e.
construct directly an AtomicString if we know we are going to need an
AtomicString).
BUG= 323739
R=eseidel
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164608
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+17 lines, -22 lines) |
Patch |
|
M |
Source/core/css/resolver/StyleBuilderConverter.h
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/css/resolver/StyleBuilderCustom.cpp
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/fileapi/FileReaderLoader.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/frame/FrameView.cpp
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/frame/Location.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/loader/FormSubmission.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/rendering/ClipPathOperation.h
|
View
|
|
3 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
Source/core/svg/SVGAElement.cpp
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/xml/XPathFunctions.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/wtf/text/AtomicString.h
|
View
|
1
|
2 chunks |
+4 lines, -9 lines |
0 comments
|
Download
|
Total messages: 6 (0 generated)
|