Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: Source/core/loader/FormSubmission.cpp

Issue 123503002: Mark the AtomicString(const String&) constructor as explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/frame/Location.cpp ('k') | Source/core/rendering/ClipPathOperation.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 if (node->isElementNode() && toElement(node)->isFormControlElement() ) { 168 if (node->isElementNode() && toElement(node)->isFormControlElement() ) {
169 submitButton = toHTMLFormControlElement(node); 169 submitButton = toHTMLFormControlElement(node);
170 break; 170 break;
171 } 171 }
172 } 172 }
173 } 173 }
174 174
175 FormSubmission::Attributes copiedAttributes; 175 FormSubmission::Attributes copiedAttributes;
176 copiedAttributes.copyFrom(attributes); 176 copiedAttributes.copyFrom(attributes);
177 if (submitButton) { 177 if (submitButton) {
178 String attributeValue; 178 AtomicString attributeValue;
179 if (!(attributeValue = submitButton->fastGetAttribute(formactionAttr)).i sNull()) 179 if (!(attributeValue = submitButton->fastGetAttribute(formactionAttr)).i sNull())
180 copiedAttributes.parseAction(attributeValue); 180 copiedAttributes.parseAction(attributeValue);
181 if (!(attributeValue = submitButton->fastGetAttribute(formenctypeAttr)). isNull()) 181 if (!(attributeValue = submitButton->fastGetAttribute(formenctypeAttr)). isNull())
182 copiedAttributes.updateEncodingType(attributeValue); 182 copiedAttributes.updateEncodingType(attributeValue);
183 if (!(attributeValue = submitButton->fastGetAttribute(formmethodAttr)).i sNull()) 183 if (!(attributeValue = submitButton->fastGetAttribute(formmethodAttr)).i sNull())
184 copiedAttributes.updateMethodType(attributeValue); 184 copiedAttributes.updateMethodType(attributeValue);
185 if (!(attributeValue = submitButton->fastGetAttribute(formtargetAttr)).i sNull()) 185 if (!(attributeValue = submitButton->fastGetAttribute(formtargetAttr)).i sNull())
186 copiedAttributes.setTarget(attributeValue); 186 copiedAttributes.setTarget(attributeValue);
187 } 187 }
188 188
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
270 frameRequest.resourceRequest().setHTTPContentType(m_contentType); 270 frameRequest.resourceRequest().setHTTPContentType(m_contentType);
271 else 271 else
272 frameRequest.resourceRequest().setHTTPContentType(m_contentType + "; boundary=" + m_boundary); 272 frameRequest.resourceRequest().setHTTPContentType(m_contentType + "; boundary=" + m_boundary);
273 } 273 }
274 274
275 frameRequest.resourceRequest().setURL(requestURL()); 275 frameRequest.resourceRequest().setURL(requestURL());
276 FrameLoader::addHTTPOriginIfNeeded(frameRequest.resourceRequest(), AtomicStr ing(m_origin)); 276 FrameLoader::addHTTPOriginIfNeeded(frameRequest.resourceRequest(), AtomicStr ing(m_origin));
277 } 277 }
278 278
279 } 279 }
OLDNEW
« no previous file with comments | « Source/core/frame/Location.cpp ('k') | Source/core/rendering/ClipPathOperation.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698