Source/core/frame/Location.cpp - Issue 123503002: Mark the AtomicString(const String&) constructor as explicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/Location.cpp

Issue 123503002: Mark the AtomicString(const String&) constructor as explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/Location.cpp

diff --git a/Source/core/frame/Location.cpp b/Source/core/frame/Location.cpp

index e38b2fde82e6b82bfb19f913ce03355271e222cd..4c6bf005be21c7b55633dfd65e1edb7465f71637 100644

--- a/Source/core/frame/Location.cpp

+++ b/Source/core/frame/Location.cpp

@@ -243,7 +243,7 @@ void Location::setLocation(const String& url, DOMWindow* activeWindow, DOMWindow

{

ASSERT(m_frame);

// We call findFrameForNavigation to handle the case of a seamless iframe correctly.

- Frame* frame = m_frame->loader().findFrameForNavigation(String(), activeWindow->document());

+ Frame* frame = m_frame->loader().findFrameForNavigation(nullAtom, activeWindow->document());

if (!frame)

return;

frame->domWindow()->setLocation(url, activeWindow, firstWindow);

« no previous file with comments | « Source/core/frame/FrameView.cpp ('k') | Source/core/loader/FormSubmission.cpp » ('j') | no next file with comments »