Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: Source/core/css/resolver/StyleBuilderCustom.cpp

Issue 123503002: Mark the AtomicString(const String&) constructor as explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 5 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
7 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 7 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
8 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 8 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
9 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 9 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
10 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 10 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
(...skipping 643 matching lines...) Expand 10 before | Expand all | Expand 10 after
654 if (value->isPrimitiveValue()) { 654 if (value->isPrimitiveValue()) {
655 CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value); 655 CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
656 if (primitiveValue->getValueID() == CSSValueNone) { 656 if (primitiveValue->getValueID() == CSSValueNone) {
657 state.style()->setClipPath(0); 657 state.style()->setClipPath(0);
658 } else if (primitiveValue->isShape()) { 658 } else if (primitiveValue->isShape()) {
659 state.style()->setClipPath(ShapeClipPathOperation::create(basicShape ForValue(state, primitiveValue->getShapeValue()))); 659 state.style()->setClipPath(ShapeClipPathOperation::create(basicShape ForValue(state, primitiveValue->getShapeValue())));
660 } else if (primitiveValue->primitiveType() == CSSPrimitiveValue::CSS_URI ) { 660 } else if (primitiveValue->primitiveType() == CSSPrimitiveValue::CSS_URI ) {
661 String cssURLValue = primitiveValue->getStringValue(); 661 String cssURLValue = primitiveValue->getStringValue();
662 KURL url = state.document().completeURL(cssURLValue); 662 KURL url = state.document().completeURL(cssURLValue);
663 // FIXME: It doesn't work with forward or external SVG references (s ee https://bugs.webkit.org/show_bug.cgi?id=90405) 663 // FIXME: It doesn't work with forward or external SVG references (s ee https://bugs.webkit.org/show_bug.cgi?id=90405)
664 state.style()->setClipPath(ReferenceClipPathOperation::create(cssURL Value, url.fragmentIdentifier())); 664 state.style()->setClipPath(ReferenceClipPathOperation::create(cssURL Value, AtomicString(url.fragmentIdentifier())));
665 } 665 }
666 } 666 }
667 } 667 }
668 668
669 void StyleBuilderFunctions::applyInitialCSSPropertyWebkitFontVariantLigatures(St yleResolverState& state) 669 void StyleBuilderFunctions::applyInitialCSSPropertyWebkitFontVariantLigatures(St yleResolverState& state)
670 { 670 {
671 state.fontBuilder().setFontVariantLigaturesInitial(); 671 state.fontBuilder().setFontVariantLigaturesInitial();
672 } 672 }
673 673
674 void StyleBuilderFunctions::applyInheritCSSPropertyWebkitFontVariantLigatures(St yleResolverState& state) 674 void StyleBuilderFunctions::applyInheritCSSPropertyWebkitFontVariantLigatures(St yleResolverState& state)
(...skipping 1466 matching lines...) Expand 10 before | Expand all | Expand 10 after
2141 break; 2141 break;
2142 } 2142 }
2143 case CSSPropertyEnableBackground: 2143 case CSSPropertyEnableBackground:
2144 // Silently ignoring this property for now 2144 // Silently ignoring this property for now
2145 // http://bugs.webkit.org/show_bug.cgi?id=6022 2145 // http://bugs.webkit.org/show_bug.cgi?id=6022
2146 break; 2146 break;
2147 } 2147 }
2148 } 2148 }
2149 2149
2150 } // namespace WebCore 2150 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/css/resolver/StyleBuilderConverter.h ('k') | Source/core/fileapi/FileReaderLoader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698