Source/core/loader/FormSubmission.cpp - Issue 123503002: Mark the AtomicString(const String&) constructor as explicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/FormSubmission.cpp

Issue 123503002: Mark the AtomicString(const String&) constructor as explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Index: Source/core/loader/FormSubmission.cpp

diff --git a/Source/core/loader/FormSubmission.cpp b/Source/core/loader/FormSubmission.cpp

index 6bfd7105b19a0407b66ef452b82421a9105a4aaa..bf46b2694dbd1f3d5e1bfa9ef353617d142e381c 100644

--- a/Source/core/loader/FormSubmission.cpp

+++ b/Source/core/loader/FormSubmission.cpp

@@ -175,7 +175,7 @@ PassRefPtr<FormSubmission> FormSubmission::create(HTMLFormElement* form, const A

FormSubmission::Attributes copiedAttributes;

copiedAttributes.copyFrom(attributes);

if (submitButton) {

- String attributeValue;

+ AtomicString attributeValue;

if (!(attributeValue = submitButton->fastGetAttribute(formactionAttr)).isNull())

copiedAttributes.parseAction(attributeValue);

if (!(attributeValue = submitButton->fastGetAttribute(formenctypeAttr)).isNull())

« no previous file with comments | « Source/core/frame/Location.cpp ('k') | Source/core/rendering/ClipPathOperation.h » ('j') | no next file with comments »