Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1142)

Unified Diff: Source/core/svg/SVGAElement.cpp

Issue 123503002: Mark the AtomicString(const String&) constructor as explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/ClipPathOperation.h ('k') | Source/core/xml/XPathFunctions.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGAElement.cpp
diff --git a/Source/core/svg/SVGAElement.cpp b/Source/core/svg/SVGAElement.cpp
index 4f3536c6e349c6326780fdf4f39491df831ddb18..2f51ae789f0aba22abb4861c6bbe9fc88472ed33 100644
--- a/Source/core/svg/SVGAElement.cpp
+++ b/Source/core/svg/SVGAElement.cpp
@@ -172,9 +172,9 @@ void SVGAElement::defaultEventHandler(Event* event)
return;
}
- String target = this->target();
+ AtomicString target = this->target();
if (target.isEmpty() && fastGetAttribute(XLinkNames::showAttr) == "new")
- target = "_blank";
+ target = AtomicString("_blank", AtomicString::ConstructFromLiteral);
event->setDefaultHandled();
Frame* frame = document().frame();
« no previous file with comments | « Source/core/rendering/ClipPathOperation.h ('k') | Source/core/xml/XPathFunctions.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698