Source/core/css/resolver/StyleBuilderConverter.h - Issue 123503002: Mark the AtomicString(const String&) constructor as explicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/StyleBuilderConverter.h

Issue 123503002: Mark the AtomicString(const String&) constructor as explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/resolver/StyleBuilderConverter.h

diff --git a/Source/core/css/resolver/StyleBuilderConverter.h b/Source/core/css/resolver/StyleBuilderConverter.h

index d7d8a800f27722590956b02838922aee8e5c0ead..68cbb7fa84d599c401f9e4598df13056726b43ff 100644

--- a/Source/core/css/resolver/StyleBuilderConverter.h

+++ b/Source/core/css/resolver/StyleBuilderConverter.h

@@ -94,7 +94,7 @@ AtomicString StyleBuilderConverter::convertString(StyleResolverState&, CSSValue*

CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);

if (primitiveValue->getValueID() == IdForNone)

return nullAtom;

- return primitiveValue->getStringValue();

+ return AtomicString(primitiveValue->getStringValue());

}

} // namespace WebCore

« no previous file with comments | « no previous file | Source/core/css/resolver/StyleBuilderCustom.cpp » ('j') | no next file with comments »