Remove 'blink::WebSerializedOrigin' (6/6)

Source/platform/exported/WebSecurityOrigin.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 117 matching lines @@
     ASSERT(m_private);
     return createDatabaseIdentifierFromSecurityOrigin(m_private);
 }
 
 bool WebSecurityOrigin::canAccessPasswordManager() const
 {
     ASSERT(m_private);
     return m_private->canAccessPasswordManager();
 }
 
+WebSecurityOrigin::WebSecurityOrigin(SecurityOrigin* origin)
+    : m_private(static_cast<WebSecurityOriginPrivate*>(origin->isolatedCopy().leakRef()))

[Mike West, 2015/07/10 14:02:31]

This feels a little ugly. If you have suggestions, I'd love to hear them.

[Peter Beverloo, 2015/07/10 14:27:03]

The obvious option would be for ExecutionContext::securityOrigin() to return a
RefPtr, which matches the underlying type. It'll be a non-trivial clean-up
though.

Since we can't rely on where SecurityOrigin* comes from (it could be on stack),
this seems fine.

+{
+}
+
 WebSecurityOrigin::WebSecurityOrigin(const WTF::PassRefPtr<SecurityOrigin>& origin)
     : m_private(static_cast<WebSecurityOriginPrivate*>(origin.leakRef()))
 {
 }
 
 WebSecurityOrigin& WebSecurityOrigin::operator=(const WTF::PassRefPtr<SecurityOrigin>& origin)
 {
     assign(static_cast<WebSecurityOriginPrivate*>(origin.leakRef()));
     return *this;
 }
@@ skipping 15 matching lines @@
         m_private->deref();
     m_private = p;
 }
 
 void WebSecurityOrigin::grantLoadLocalResources() const
 {
     get()->grantLoadLocalResources();
 }
 
 } // namespace blink