Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 12313142: Revert 184837 (Closed)

Created:
7 years, 9 months ago by Albert Bodenhamer
Modified:
7 years, 9 months ago
Reviewers:
cduvall
CC:
chromium-reviews, Aaron Boodman, rginda+watch_chromium.org, James Su, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Revert 184837 Looks like it caused http://build.chromium.org/p/chromium.win/builders/Interactive%20Tests%20%28dbg%29/builds/34570 > Set up V8 bindings for extension/app APIs when they're first used, not on > context creation. This should gives us a significant reduction in extension/app > startup time and slightly better memory usage. > > It also gives us better error messages, the chance to complete the > implementation of API features, and eventually the ability to expose select > extension APIs (e.g. extension.sendMessage) to web pages. > > BUG=163678, 120070, 55316, 177163 > TBR=ben@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/11571014 TBR=cduvall@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184860

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+698 lines, -2302 lines) Patch
M chrome/browser/autocomplete/autocomplete_match.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_renderer.gypi View 4 chunks +4 lines, -8 lines 0 comments Download
M chrome/common/extensions/api/extension_api.h View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/common/extensions/api/extension_api.cc View 2 chunks +4 lines, -15 lines 0 comments Download
M chrome/common/extensions/api/extension_api_unittest.cc View 3 chunks +26 lines, -23 lines 0 comments Download
M chrome/common/extensions/api/test.json View 1 chunk +0 lines, -199 lines 0 comments Download
M chrome/common/extensions/features/feature.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/common/extensions/features/feature.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/renderer/extensions/api_definitions_natives.h View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/renderer/extensions/api_definitions_natives.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/renderer/extensions/app_bindings.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/extensions/app_bindings.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/app_runtime_custom_bindings.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/renderer/extensions/app_runtime_custom_bindings.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/app_window_custom_bindings.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/renderer/extensions/app_window_custom_bindings.cc View 2 chunks +3 lines, -4 lines 0 comments Download
D chrome/renderer/extensions/binding_generating_native_handler.h View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/renderer/extensions/binding_generating_native_handler.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M chrome/renderer/extensions/chrome_v8_context.h View 4 chunks +4 lines, -8 lines 0 comments Download
M chrome/renderer/extensions/chrome_v8_context.cc View 7 chunks +11 lines, -36 lines 0 comments Download
M chrome/renderer/extensions/chrome_v8_context_set.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/chrome_v8_extension.h View 3 chunks +17 lines, -17 lines 0 comments Download
M chrome/renderer/extensions/chrome_v8_extension.cc View 1 chunk +44 lines, -16 lines 0 comments Download
M chrome/renderer/extensions/dispatcher.h View 3 chunks +2 lines, -10 lines 0 comments Download
M chrome/renderer/extensions/dispatcher.cc View 18 chunks +68 lines, -201 lines 0 comments Download
M chrome/renderer/extensions/event_bindings.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/event_bindings.cc View 12 chunks +19 lines, -23 lines 0 comments Download
M chrome/renderer/extensions/event_unittest.cc View 12 chunks +22 lines, -36 lines 0 comments Download
M chrome/renderer/extensions/extension_custom_bindings.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/renderer/extensions/extension_custom_bindings.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/renderer/extensions/extension_helper.h View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/renderer/extensions/extension_helper.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/renderer/extensions/file_browser_handler_custom_bindings.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/renderer/extensions/file_browser_handler_custom_bindings.cc View 3 chunks +13 lines, -14 lines 0 comments Download
M chrome/renderer/extensions/file_browser_private_custom_bindings.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/renderer/extensions/file_browser_private_custom_bindings.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M chrome/renderer/extensions/file_system_natives.h View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/renderer/extensions/file_system_natives.cc View 4 chunks +15 lines, -15 lines 0 comments Download
M chrome/renderer/extensions/i18n_custom_bindings.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/i18n_custom_bindings.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/renderer/extensions/json_schema_unittest.cc View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/renderer/extensions/miscellaneous_bindings.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/renderer/extensions/miscellaneous_bindings.cc View 3 chunks +5 lines, -9 lines 0 comments Download
M chrome/renderer/extensions/module_system.h View 11 chunks +12 lines, -48 lines 0 comments Download
M chrome/renderer/extensions/module_system.cc View 13 chunks +36 lines, -120 lines 0 comments Download
M chrome/renderer/extensions/module_system_unittest.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M chrome/renderer/extensions/native_handler.h View 1 chunk +38 lines, -4 lines 0 comments Download
A + chrome/renderer/extensions/native_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/renderer/extensions/object_backed_native_handler.h View 1 chunk +0 lines, -70 lines 0 comments Download
D chrome/renderer/extensions/object_backed_native_handler.cc View 1 chunk +0 lines, -74 lines 0 comments Download
M chrome/renderer/extensions/page_capture_custom_bindings.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/renderer/extensions/page_capture_custom_bindings.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M chrome/renderer/extensions/request_sender.h View 4 chunks +5 lines, -9 lines 0 comments Download
M chrome/renderer/extensions/request_sender.cc View 7 chunks +41 lines, -36 lines 0 comments Download
M chrome/renderer/extensions/runtime_custom_bindings.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/runtime_custom_bindings.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M chrome/renderer/extensions/send_request_natives.h View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/renderer/extensions/send_request_natives.cc View 2 chunks +7 lines, -10 lines 0 comments Download
M chrome/renderer/extensions/set_icon_natives.h View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/renderer/extensions/set_icon_natives.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/renderer/extensions/tabs_custom_bindings.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/tabs_custom_bindings.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/renderer/extensions/v8_schema_registry.h View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/renderer/resources/extensions/apitest.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/renderer/resources/extensions/app_custom_bindings.js View 3 chunks +6 lines, -11 lines 0 comments Download
M chrome/renderer/resources/extensions/app_runtime_custom_bindings.js View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/renderer/resources/extensions/app_window_custom_bindings.js View 3 chunks +4 lines, -12 lines 0 comments Download
D chrome/renderer/resources/extensions/binding.js View 1 chunk +0 lines, -407 lines 0 comments Download
M chrome/renderer/resources/extensions/bluetooth_custom_bindings.js View 2 chunks +3 lines, -8 lines 0 comments Download
M chrome/renderer/resources/extensions/browser_action_custom_bindings.js View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/renderer/resources/extensions/content_settings_custom_bindings.js View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/renderer/resources/extensions/context_menus_custom_bindings.js View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/renderer/resources/extensions/declarative_content_custom_bindings.js View 2 chunks +11 lines, -15 lines 0 comments Download
M chrome/renderer/resources/extensions/declarative_webrequest_custom_bindings.js View 2 chunks +26 lines, -32 lines 0 comments Download
M chrome/renderer/resources/extensions/event.js View 15 chunks +22 lines, -24 lines 0 comments Download
M chrome/renderer/resources/extensions/experimental.media_galleries_custom_bindings.js View 2 chunks +5 lines, -6 lines 0 comments Download
MM chrome/renderer/resources/extensions/experimental.offscreenTabs_custom_bindings.js View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/renderer/resources/extensions/extension_custom_bindings.js View 4 chunks +16 lines, -17 lines 0 comments Download
M chrome/renderer/resources/extensions/file_browser_handler_custom_bindings.js View 3 chunks +3 lines, -9 lines 0 comments Download
M chrome/renderer/resources/extensions/file_browser_private_custom_bindings.js View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/renderer/resources/extensions/file_system_custom_bindings.js View 2 chunks +9 lines, -14 lines 0 comments Download
M chrome/renderer/resources/extensions/i18n_custom_bindings.js View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/renderer/resources/extensions/input.ime_custom_bindings.js View 2 chunks +9 lines, -13 lines 0 comments Download
M chrome/renderer/resources/extensions/json_schema.js View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/renderer/resources/extensions/last_error.js View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/renderer/resources/extensions/media_galleries_custom_bindings.js View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/renderer/resources/extensions/miscellaneous_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/notification_custom_bindings.js View 3 chunks +5 lines, -8 lines 0 comments Download
M chrome/renderer/resources/extensions/omnibox_custom_bindings.js View 3 chunks +2 lines, -6 lines 0 comments Download
M chrome/renderer/resources/extensions/page_action_custom_bindings.js View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/renderer/resources/extensions/page_actions_custom_bindings.js View 1 chunk +6 lines, -8 lines 0 comments Download
M chrome/renderer/resources/extensions/page_capture_custom_bindings.js View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/renderer/resources/extensions/permissions_custom_bindings.js View 2 chunks +7 lines, -11 lines 0 comments Download
M chrome/renderer/resources/extensions/runtime_custom_bindings.js View 7 chunks +9 lines, -14 lines 0 comments Download
A + chrome/renderer/resources/extensions/schema_generated_bindings.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/renderer/resources/extensions/schema_utils.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/resources/extensions/send_request.js View 3 chunks +1 line, -3 lines 0 comments Download
M chrome/renderer/resources/extensions/storage_custom_bindings.js View 3 chunks +4 lines, -7 lines 0 comments Download
M chrome/renderer/resources/extensions/sync_file_system_custom_bindings.js View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/renderer/resources/extensions/system_indicator_custom_bindings.js View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/renderer/resources/extensions/tab_capture_custom_bindings.js View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/renderer/resources/extensions/tabs_custom_bindings.js View 2 chunks +4 lines, -9 lines 0 comments Download
D chrome/renderer/resources/extensions/test_custom_bindings.js View 1 chunk +0 lines, -291 lines 0 comments Download
M chrome/renderer/resources/extensions/tts_custom_bindings.js View 4 chunks +3 lines, -8 lines 0 comments Download
M chrome/renderer/resources/extensions/tts_engine_custom_bindings.js View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/renderer/resources/extensions/types_custom_bindings.js View 2 chunks +3 lines, -7 lines 0 comments Download
M chrome/renderer/resources/extensions/utils.js View 2 chunks +0 lines, -13 lines 0 comments Download
M chrome/renderer/resources/extensions/web_request_custom_bindings.js View 6 chunks +7 lines, -12 lines 0 comments Download
M chrome/renderer/resources/extensions/web_request_internal_custom_bindings.js View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/renderer/resources/extensions/web_view.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/renderer/resources/extensions/webstore_custom_bindings.js View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/resources/renderer_resources.grd View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/module_system_test.cc View 4 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Albert Bodenhamer
7 years, 9 months ago (2013-02-27 03:30:56 UTC) #1
Albert Bodenhamer
Committed patchset #1 manually as r184860.
7 years, 9 months ago (2013-02-27 03:31:48 UTC) #2
Mark P
It possibly also caused http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%283%29/builds/16347/steps/browser_tests/logs/stdio [470/539] 1355.15s PlatformAppBrowserTest.DisallowStorage (45.77s) Note: Google Test filter = PlatformAppBrowserTest.DisallowStorage ...
7 years, 9 months ago (2013-02-27 03:40:17 UTC) #3
Mark P
Possibly also caused http://build.chromium.org/p/chromium.win/waterfall?builder=XP%20Tests%20(dbg)(4) [398/547] 1815.74s PlatformAppBrowserTest.LaunchNoFile (47.97s) Note: Google Test filter = PlatformAppBrowserTest.LaunchNoFile [==========] ...
7 years, 9 months ago (2013-02-27 04:15:17 UTC) #4
Mark P
7 years, 9 months ago (2013-02-27 04:16:52 UTC) #5
Message was sent while issue was closed.
And
http://build.chromium.org/p/chromium.win/waterfall?builder=Win7%20Tests%20(db...

[ 15/503]  51.93s PlatformAppBrowserTest.LaunchWithRelativeFile (46.03s)
Note: Google Test filter = PlatformAppBrowserTest.LaunchWithRelativeFile
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from PlatformAppBrowserTest, where TypeParam = 
[ RUN      ] PlatformAppBrowserTest.LaunchWithRelativeFile
[0226/190109:ERROR:logging_chrome.cc(310)] Unable to initialize logging to
E:\b\build\slave\Win7_Tests__dbg__3_\build\src\build\Debug\chrome_debug.log:
Access is denied.
[0226/190109:ERROR:gl_surface_egl.cc(94)] eglInitialize failed with error
UNKNOWN
[0226/190109:ERROR:gl_surface_win.cc(54)] GLSurfaceEGL::InitializeOneOff failed.
[648:1644:0226/190110:435117:ERROR:ipc_channel_win.cc(132)] pipe error: 109
[0226/190110:ERROR:logging_chrome.cc(310)] Unable to initialize logging to
E:\b\build\slave\Win7_Tests__dbg__3_\build\src\build\Debug\chrome_debug.log:
Access is denied.
[0226/190110:ERROR:gl_surface_egl.cc(94)] eglInitialize failed with error
UNKNOWN
[0226/190110:ERROR:gl_surface_win.cc(54)] GLSurfaceEGL::InitializeOneOff failed.
[0226/190113:ERROR:logging_chrome.cc(310)] Unable to initialize logging to
E:\b\build\slave\Win7_Tests__dbg__3_\build\src\build\Debug\chrome_debug.log:
Access is denied.
[0226/190113:ERROR:gl_surface_egl.cc(94)] eglInitialize failed with error
UNKNOWN
[0226/190113:ERROR:gl_surface_win.cc(54)] GLSurfaceEGL::InitializeOneOff failed.
[648:3372:0226/190114:439844:ERROR:textfield.h(162)] NOT IMPLEMENTED
[0226/190152:ERROR:test_launcher.cc(365)] Test timeout (45000 ms) exceeded for
PlatformAppBrowserTest.LaunchWithRelativeFile
Starting tests...
IMPORTANT DEBUGGING NOTE: each test is run inside its own process.
For debugging a test inside a debugger, use the
--gtest_filter=<your_test_name> flag along with either
--single_process (to run the test in one launcher/browser process) or
--single-process (to do the above, and also run Chrome in single-process mode).
1 test run
1 test failed (0 ignored)
Failing tests:
PlatformAppBrowserTest.LaunchWithRelativeFile

Powered by Google App Engine
This is Rietveld 408576698