Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Unified Diff: chrome/renderer/resources/extensions/file_browser_handler_custom_bindings.js

Issue 12313142: Revert 184837 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/file_browser_handler_custom_bindings.js
===================================================================
--- chrome/renderer/resources/extensions/file_browser_handler_custom_bindings.js (revision 184858)
+++ chrome/renderer/resources/extensions/file_browser_handler_custom_bindings.js (working copy)
@@ -2,16 +2,12 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// Custom binding for the fileBrowserHandler API.
+// Custom bindings for the fileBrowserHandler API.
-var binding = require('binding').Binding.create('fileBrowserHandler');
-
var fileBrowserNatives = requireNative('file_browser_handler');
var GetExternalFileEntry = fileBrowserNatives.GetExternalFileEntry;
var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
-var fileBrowserHandlerInternal = require('binding').Binding.create(
- 'fileBrowserHandlerInternal').generate();
chromeHidden.Event.registerArgumentMassager('fileBrowserHandler.onExecute',
function(args, dispatch) {
@@ -32,7 +28,7 @@
dispatch(args);
});
-binding.registerCustomHook(function(bindingsAPI) {
+chromeHidden.registerCustomHook('fileBrowserHandler', function(bindingsAPI) {
var apiFunctions = bindingsAPI.apiFunctions;
apiFunctions.setHandleRequest('selectFile',
@@ -50,9 +46,7 @@
externalCallback(result);
}
- return fileBrowserHandlerInternal.selectFile(
+ return chromeHidden.internalAPIs.fileBrowserHandlerInternal.selectFile(
selectionParams, internalCallback.bind(null, callback));
});
});
-
-exports.binding = binding.generate();

Powered by Google App Engine
This is Rietveld 408576698