Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3025)

Unified Diff: chrome/common/extensions/api/extension_api_unittest.cc

Issue 12313142: Revert 184837 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/api/extension_api.cc ('k') | chrome/common/extensions/api/test.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/extension_api_unittest.cc
===================================================================
--- chrome/common/extensions/api/extension_api_unittest.cc (revision 184858)
+++ chrome/common/extensions/api/extension_api_unittest.cc (working copy)
@@ -234,29 +234,32 @@
scoped_ptr<ExtensionAPI> extension_api(
ExtensionAPI::CreateWithDefaultConfiguration());
- std::set<std::string> privileged_apis = extension_api->GetAPIsForContext(
- Feature::BLESSED_EXTENSION_CONTEXT, extension.get(), GURL());
+ scoped_ptr<std::set<std::string> > privileged_apis =
+ extension_api->GetAPIsForContext(
+ Feature::BLESSED_EXTENSION_CONTEXT, extension.get(), GURL());
- std::set<std::string> unprivileged_apis = extension_api->GetAPIsForContext(
- Feature::UNBLESSED_EXTENSION_CONTEXT, extension.get(), GURL());
+ scoped_ptr<std::set<std::string> > unprivileged_apis =
+ extension_api->GetAPIsForContext(
+ Feature::UNBLESSED_EXTENSION_CONTEXT, extension.get(), GURL());
- std::set<std::string> content_script_apis = extension_api->GetAPIsForContext(
- Feature::CONTENT_SCRIPT_CONTEXT, extension.get(), GURL());
+ scoped_ptr<std::set<std::string> > content_script_apis =
+ extension_api->GetAPIsForContext(
+ Feature::CONTENT_SCRIPT_CONTEXT, extension.get(), GURL());
// "storage" is completely unprivileged.
- EXPECT_EQ(1u, privileged_apis.count("storage"));
- EXPECT_EQ(1u, unprivileged_apis.count("storage"));
- EXPECT_EQ(1u, content_script_apis.count("storage"));
+ EXPECT_EQ(1u, privileged_apis->count("storage"));
+ EXPECT_EQ(1u, unprivileged_apis->count("storage"));
+ EXPECT_EQ(1u, content_script_apis->count("storage"));
// "extension" is partially unprivileged.
- EXPECT_EQ(1u, privileged_apis.count("extension"));
- EXPECT_EQ(1u, unprivileged_apis.count("extension"));
- EXPECT_EQ(1u, content_script_apis.count("extension"));
+ EXPECT_EQ(1u, privileged_apis->count("extension"));
+ EXPECT_EQ(1u, unprivileged_apis->count("extension"));
+ EXPECT_EQ(1u, content_script_apis->count("extension"));
// "history" is entirely privileged.
- EXPECT_EQ(1u, privileged_apis.count("history"));
- EXPECT_EQ(0u, unprivileged_apis.count("history"));
- EXPECT_EQ(0u, content_script_apis.count("history"));
+ EXPECT_EQ(1u, privileged_apis->count("history"));
+ EXPECT_EQ(0u, unprivileged_apis->count("history"));
+ EXPECT_EQ(0u, content_script_apis->count("history"));
}
TEST(ExtensionAPI, ExtensionWithDependencies) {
@@ -267,10 +270,10 @@
CreateExtensionWithPermission("ttsEngine");
scoped_ptr<ExtensionAPI> api(
ExtensionAPI::CreateWithDefaultConfiguration());
- std::set<std::string> apis = api->GetAPIsForContext(
+ scoped_ptr<std::set<std::string> > apis = api->GetAPIsForContext(
Feature::BLESSED_EXTENSION_CONTEXT, extension.get(), GURL());
- EXPECT_EQ(1u, apis.count("ttsEngine"));
- EXPECT_EQ(1u, apis.count("tts"));
+ EXPECT_EQ(1u, apis->count("ttsEngine"));
+ EXPECT_EQ(1u, apis->count("tts"));
}
// Conversely, extension with the "tts" permission but not the "ttsEngine"
@@ -280,18 +283,18 @@
CreateExtensionWithPermission("tts");
scoped_ptr<ExtensionAPI> api(
ExtensionAPI::CreateWithDefaultConfiguration());
- std::set<std::string> apis = api->GetAPIsForContext(
+ scoped_ptr<std::set<std::string> > apis = api->GetAPIsForContext(
Feature::BLESSED_EXTENSION_CONTEXT, extension.get(), GURL());
- EXPECT_EQ(0u, apis.count("ttsEngine"));
- EXPECT_EQ(1u, apis.count("tts"));
+ EXPECT_EQ(0u, apis->count("ttsEngine"));
+ EXPECT_EQ(1u, apis->count("tts"));
}
}
bool MatchesURL(
ExtensionAPI* api, const std::string& api_name, const std::string& url) {
- std::set<std::string> apis =
+ scoped_ptr<std::set<std::string> > apis =
api->GetAPIsForContext(Feature::WEB_PAGE_CONTEXT, NULL, GURL(url));
- return apis.count(api_name);
+ return apis->count(api_name);
}
TEST(ExtensionAPI, URLMatching) {
« no previous file with comments | « chrome/common/extensions/api/extension_api.cc ('k') | chrome/common/extensions/api/test.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698