Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3772)

Unified Diff: chrome/renderer/extensions/file_system_natives.cc

Issue 12313142: Revert 184837 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/file_system_natives.h ('k') | chrome/renderer/extensions/i18n_custom_bindings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/file_system_natives.cc
===================================================================
--- chrome/renderer/extensions/file_system_natives.cc (revision 184858)
+++ chrome/renderer/extensions/file_system_natives.cc (working copy)
@@ -18,23 +18,14 @@
#include "webkit/fileapi/file_system_types.h"
#include "webkit/fileapi/file_system_util.h"
-namespace extensions {
+namespace {
-FileSystemNatives::FileSystemNatives(v8::Handle<v8::Context> context)
- : ObjectBackedNativeHandler(context) {
- RouteFunction("GetFileEntry",
- base::Bind(&FileSystemNatives::GetFileEntry, base::Unretained(this)));
- RouteFunction("GetIsolatedFileSystem",
- base::Bind(&FileSystemNatives::GetIsolatedFileSystem,
- base::Unretained(this)));
-}
-
-v8::Handle<v8::Value> FileSystemNatives::GetIsolatedFileSystem(
+static v8::Handle<v8::Value> GetIsolatedFileSystem(
const v8::Arguments& args) {
DCHECK(args.Length() == 1 || args.Length() == 2);
DCHECK(args[0]->IsString());
std::string file_system_id(*v8::String::Utf8Value(args[0]));
- WebKit::WebFrame* webframe = WebKit::WebFrame::frameForContext(v8_context());
+ WebKit::WebFrame* webframe = WebKit::WebFrame::frameForCurrentContext();
DCHECK(webframe);
GURL context_url =
@@ -63,8 +54,7 @@
WebKit::WebString::fromUTF8(root));
}
-v8::Handle<v8::Value> FileSystemNatives::GetFileEntry(
- const v8::Arguments& args) {
+static v8::Handle<v8::Value> GetFileEntry(const v8::Arguments& args) {
DCHECK(args.Length() == 5);
DCHECK(args[0]->IsString());
std::string type_string = *v8::String::Utf8Value(args[0]->ToString());
@@ -87,7 +77,7 @@
DCHECK(args[4]->IsBoolean());
bool is_directory = args[4]->BooleanValue();
- WebKit::WebFrame* webframe = WebKit::WebFrame::frameForContext(v8_context());
+ WebKit::WebFrame* webframe = WebKit::WebFrame::frameForCurrentContext();
DCHECK(webframe);
return webframe->createFileEntry(
type,
@@ -97,4 +87,14 @@
is_directory);
}
+} // namespace
+
+namespace extensions {
+
+FileSystemNatives::FileSystemNatives()
+ : ChromeV8Extension(NULL) {
+ RouteStaticFunction("GetFileEntry", &GetFileEntry);
+ RouteStaticFunction("GetIsolatedFileSystem", &GetIsolatedFileSystem);
+}
+
} // namespace extensions
« no previous file with comments | « chrome/renderer/extensions/file_system_natives.h ('k') | chrome/renderer/extensions/i18n_custom_bindings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698