Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5759)

Unified Diff: chrome/renderer/resources/extensions/storage_custom_bindings.js

Issue 12313142: Revert 184837 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/storage_custom_bindings.js
===================================================================
--- chrome/renderer/resources/extensions/storage_custom_bindings.js (revision 184858)
+++ chrome/renderer/resources/extensions/storage_custom_bindings.js (working copy)
@@ -2,15 +2,14 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// Custom binding for the storage API.
+// Custom bindings for the storage API.
-var binding = require('binding').Binding.create('storage');
-
+var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
var normalizeArgumentsAndValidate =
require('schemaUtils').normalizeArgumentsAndValidate
var sendRequest = require('sendRequest').sendRequest;
-binding.registerCustomType('storage.StorageArea', function() {
+chromeHidden.registerCustomType('storage.StorageArea', function() {
function extendSchema(schema) {
var extendedSchema = schema.slice();
extendedSchema.unshift({'type': 'string'});
@@ -22,7 +21,7 @@
// storage.sync.get('foo') -> (binds to) ->
// storage.get('sync', 'foo').
//
- // TODO(kalman): Put as a method on CustombindingObject and re-use (or
+ // TODO(kalman): Put as a method on CustomBindingsObject and re-use (or
// even generate) for other APIs that need to do this. Same for other
// callers of registerCustomType().
var self = this;
@@ -44,5 +43,3 @@
return StorageArea;
});
-
-exports.binding = binding.generate();

Powered by Google App Engine
This is Rietveld 408576698