Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: chrome/renderer/extensions/module_system_unittest.cc

Issue 12313142: Revert 184837 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/base/module_system_test.h" 5 #include "chrome/test/base/module_system_test.h"
6 #include "base/memory/scoped_ptr.h" 6 #include "base/memory/scoped_ptr.h"
7 #include "chrome/renderer/extensions/module_system.h" 7 #include "chrome/renderer/extensions/module_system.h"
8 8
9 // TODO(cduvall/kalman): Put this file in extensions namespace.
10 using extensions::ModuleSystem; 9 using extensions::ModuleSystem;
11 using extensions::NativeHandler; 10 using extensions::NativeHandler;
12 using extensions::ObjectBackedNativeHandler;
13 11
14 class CounterNatives : public ObjectBackedNativeHandler { 12 class CounterNatives : public NativeHandler {
15 public: 13 public:
16 explicit CounterNatives(v8::Handle<v8::Context> context) 14 explicit CounterNatives(v8::Isolate* isolate)
17 : ObjectBackedNativeHandler(context), counter_(0) { 15 : NativeHandler(isolate), counter_(0) {
18 RouteFunction("Get", base::Bind(&CounterNatives::Get, 16 RouteFunction("Get", base::Bind(&CounterNatives::Get,
19 base::Unretained(this))); 17 base::Unretained(this)));
20 RouteFunction("Increment", base::Bind(&CounterNatives::Increment, 18 RouteFunction("Increment", base::Bind(&CounterNatives::Increment,
21 base::Unretained(this))); 19 base::Unretained(this)));
22 } 20 }
23 21
24 v8::Handle<v8::Value> Get(const v8::Arguments& args) { 22 v8::Handle<v8::Value> Get(const v8::Arguments& args) {
25 return v8::Integer::New(counter_); 23 return v8::Integer::New(counter_);
26 } 24 }
27 25
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 "assert.AssertTrue(object.thing.y() == 10);" 166 "assert.AssertTrue(object.thing.y() == 10);"
169 "assert.AssertTrue(object.thing.z == 1);" 167 "assert.AssertTrue(object.thing.z == 1);"
170 ); 168 );
171 module_system_->Require("test"); 169 module_system_->Require("test");
172 } 170 }
173 171
174 TEST_F(ModuleSystemTest, TestLazyFieldIsOnlyEvaledOnce) { 172 TEST_F(ModuleSystemTest, TestLazyFieldIsOnlyEvaledOnce) {
175 ModuleSystem::NativesEnabledScope natives_enabled_scope(module_system_.get()); 173 ModuleSystem::NativesEnabledScope natives_enabled_scope(module_system_.get());
176 module_system_->RegisterNativeHandler( 174 module_system_->RegisterNativeHandler(
177 "counter", 175 "counter",
178 scoped_ptr<NativeHandler>(new CounterNatives(v8::Context::GetCurrent()))); 176 scoped_ptr<NativeHandler>(new CounterNatives(v8::Isolate::GetCurrent())));
179 RegisterModule("lazy", 177 RegisterModule("lazy",
180 "requireNative('counter').Increment();" 178 "requireNative('counter').Increment();"
181 "exports.x = 5;"); 179 "exports.x = 5;");
182 180
183 v8::Handle<v8::Object> object = CreateGlobal("object"); 181 v8::Handle<v8::Object> object = CreateGlobal("object");
184 182
185 module_system_->SetLazyField(object, "x", "lazy", "x"); 183 module_system_->SetLazyField(object, "x", "lazy", "x");
186 184
187 RegisterModule("test", 185 RegisterModule("test",
188 "var assert = requireNative('assert');" 186 "var assert = requireNative('assert');"
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 RegisterModule("test", 220 RegisterModule("test",
223 "var assert = requireNative('assert');" 221 "var assert = requireNative('assert');"
224 "assert.AssertTrue(object.thing.x == 5);"); 222 "assert.AssertTrue(object.thing.x == 5);");
225 module_system_->Require("test"); 223 module_system_->Require("test");
226 } 224 }
227 225
228 TEST_F(ModuleSystemTest, TestModulesOnlyGetEvaledOnce) { 226 TEST_F(ModuleSystemTest, TestModulesOnlyGetEvaledOnce) {
229 ModuleSystem::NativesEnabledScope natives_enabled_scope(module_system_.get()); 227 ModuleSystem::NativesEnabledScope natives_enabled_scope(module_system_.get());
230 module_system_->RegisterNativeHandler( 228 module_system_->RegisterNativeHandler(
231 "counter", 229 "counter",
232 scoped_ptr<NativeHandler>(new CounterNatives(v8::Context::GetCurrent()))); 230 scoped_ptr<NativeHandler>(new CounterNatives(v8::Isolate::GetCurrent())));
233 231
234 RegisterModule("incrementsWhenEvaled", 232 RegisterModule("incrementsWhenEvaled",
235 "requireNative('counter').Increment();"); 233 "requireNative('counter').Increment();");
236 RegisterModule("test", 234 RegisterModule("test",
237 "var assert = requireNative('assert');" 235 "var assert = requireNative('assert');"
238 "var counter = requireNative('counter');" 236 "var counter = requireNative('counter');"
239 "assert.AssertTrue(counter.Get() == 0);" 237 "assert.AssertTrue(counter.Get() == 0);"
240 "require('incrementsWhenEvaled');" 238 "require('incrementsWhenEvaled');"
241 "assert.AssertTrue(counter.Get() == 1);" 239 "assert.AssertTrue(counter.Get() == 1);"
242 "require('incrementsWhenEvaled');" 240 "require('incrementsWhenEvaled');"
(...skipping 11 matching lines...) Expand all
254 } 252 }
255 253
256 TEST_F(ModuleSystemTest, TestOverrideNonExistentNativeHandler) { 254 TEST_F(ModuleSystemTest, TestOverrideNonExistentNativeHandler) {
257 ModuleSystem::NativesEnabledScope natives_enabled_scope(module_system_.get()); 255 ModuleSystem::NativesEnabledScope natives_enabled_scope(module_system_.get());
258 OverrideNativeHandler("thing", "exports.x = 5;"); 256 OverrideNativeHandler("thing", "exports.x = 5;");
259 RegisterModule("test", 257 RegisterModule("test",
260 "var assert = requireNative('assert');" 258 "var assert = requireNative('assert');"
261 "assert.AssertTrue(requireNative('thing').x == 5);"); 259 "assert.AssertTrue(requireNative('thing').x == 5);");
262 module_system_->Require("test"); 260 module_system_->Require("test");
263 } 261 }
OLDNEW
« no previous file with comments | « chrome/renderer/extensions/module_system.cc ('k') | chrome/renderer/extensions/native_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698