Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Unified Diff: chrome/renderer/resources/extensions/page_actions_custom_bindings.js

Issue 12313142: Revert 184837 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/page_actions_custom_bindings.js
===================================================================
--- chrome/renderer/resources/extensions/page_actions_custom_bindings.js (revision 184858)
+++ chrome/renderer/resources/extensions/page_actions_custom_bindings.js (working copy)
@@ -2,21 +2,19 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// Custom binding for the pageActions API.
+// Custom bindings for the pageActions API.
-var binding = require('binding').Binding.create('pageActions');
-
var pageActionsNatives = requireNative('page_actions');
var GetCurrentPageActions = pageActionsNatives.GetCurrentPageActions;
-binding.registerCustomHook(function(bindingsAPI, extensionId) {
+var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
+
+chromeHidden.registerCustomHook('pageActions',
+ function(bindingsAPI, extensionId) {
var pageActions = GetCurrentPageActions(extensionId);
- var pageActionsApi = bindingsAPI.compiledApi;
var oldStyleEventName = 'pageActions';
for (var i = 0; i < pageActions.length; ++i) {
// Setup events for each extension_id/page_action_id string we find.
- pageActionsApi[pageActions[i]] = new chrome.Event(oldStyleEventName);
+ chrome.pageActions[pageActions[i]] = new chrome.Event(oldStyleEventName);
}
});
-
-exports.binding = binding.generate();

Powered by Google App Engine
This is Rietveld 408576698