[nacltoons] Add initial frontend and physics game scenes.

[nacltoons] Add initial frontend and physics game scenes.

The only resource we are now using from the cococs sample
is the blocks.png image file.

BUG=None

Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1504

[binji, 2013-02-12 22:51:53]

lgtm

style issues: do we want to follow Cocos style or Google style? If Google style,
I'd like to see:

* MixedCase for function names (unless overriding cocos2d virtual function)
* As few cocos macros as possible
* lowercase_with_underscores for filenames.

Thoughts?

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/AppDelegate.cc
File nacltoons/src/AppDelegate.cc (right):

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/AppDelegate....
nacltoons/src/AppDelegate.cc:1: // Copyright (c) 2013 The Native Client Authors.
All rights reserved.
some of these are Native Client and some are Chromium. Which do we want?

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/FrontEnd.cc
File nacltoons/src/FrontEnd.cc (right):

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/FrontEnd.cc#...
nacltoons/src/FrontEnd.cc:15: 
nit: one space here and below

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/FrontEnd.cc#...
nacltoons/src/FrontEnd.cc:39: CCMenuItemLabel* start =
CCMenuItemLabel::create(start_label,
nit: move start_label to next line, or wrap the following line starting at (

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/FrontEnd.h
File nacltoons/src/FrontEnd.h (right):

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/FrontEnd.h#n...
nacltoons/src/FrontEnd.h:15: {
nit: { on previous line

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/GameplayScene.h
File nacltoons/src/GameplayScene.h (right):

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/GameplayScen...
nacltoons/src/GameplayScene.h:17: {
nit: { on previous line

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/GameplayScen...
nacltoons/src/GameplayScene.h:31: {
nit: { on previous line

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/PhysicsLayer.cc
File nacltoons/src/PhysicsLayer.cc (right):

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/PhysicsLayer...
nacltoons/src/PhysicsLayer.cc:26: CCSpriteBatchNode* batch =
CCSpriteBatchNode::create("blocks.png", 100);
magic number?

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/PhysicsLayer...
nacltoons/src/PhysicsLayer.cc:39: {
{ on previous line

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/PhysicsLayer...
nacltoons/src/PhysicsLayer.cc:45: {
{ on previous line

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/PhysicsLayer...
nacltoons/src/PhysicsLayer.cc:84: {
"

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/PhysicsLayer...
nacltoons/src/PhysicsLayer.cc:96: {
"

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/PhysicsLayer.h
File nacltoons/src/PhysicsLayer.h (right):

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/PhysicsLayer...
nacltoons/src/PhysicsLayer.h:16: {
{ on previous line

[Sam Clegg, 2013-02-12 22:55:09]

On 2013/02/12 22:51:53, binji wrote:
> lgtm
> 
> style issues: do we want to follow Cocos style or Google style? If Google
style,
> I'd like to see:
> 
> * MixedCase for function names (unless overriding cocos2d virtual function)
> * As few cocos macros as possible
> * lowercase_with_underscores for filenames.
> 
> Thoughts?
> 
>
https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/AppDelegate.cc
> File nacltoons/src/AppDelegate.cc (right):
> 
>
https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/AppDelegate....
> nacltoons/src/AppDelegate.cc:1: // Copyright (c) 2013 The Native Client
Authors.
> All rights reserved.
> some of these are Native Client and some are Chromium. Which do we want?
> 
> https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/FrontEnd.cc
> File nacltoons/src/FrontEnd.cc (right):
> 
>
https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/FrontEnd.cc#...
> nacltoons/src/FrontEnd.cc:15: 
> nit: one space here and below
> 
>
https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/FrontEnd.cc#...
> nacltoons/src/FrontEnd.cc:39: CCMenuItemLabel* start =
> CCMenuItemLabel::create(start_label,
> nit: move start_label to next line, or wrap the following line starting at (
> 
> https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/FrontEnd.h
> File nacltoons/src/FrontEnd.h (right):
> 
>
https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/FrontEnd.h#n...
> nacltoons/src/FrontEnd.h:15: {
> nit: { on previous line
> 
>
https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/GameplayScene.h
> File nacltoons/src/GameplayScene.h (right):
> 
>
https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/GameplayScen...
> nacltoons/src/GameplayScene.h:17: {
> nit: { on previous line
> 
>
https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/GameplayScen...
> nacltoons/src/GameplayScene.h:31: {
> nit: { on previous line
> 
>
https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/PhysicsLayer.cc
> File nacltoons/src/PhysicsLayer.cc (right):
> 
>
https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/PhysicsLayer...
> nacltoons/src/PhysicsLayer.cc:26: CCSpriteBatchNode* batch =
> CCSpriteBatchNode::create("blocks.png", 100);
> magic number?
> 
>
https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/PhysicsLayer...
> nacltoons/src/PhysicsLayer.cc:39: {
> { on previous line
> 
>
https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/PhysicsLayer...
> nacltoons/src/PhysicsLayer.cc:45: {
> { on previous line
> 
>
https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/PhysicsLayer...
> nacltoons/src/PhysicsLayer.cc:84: {
> "
> 
>
https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/PhysicsLayer...
> nacltoons/src/PhysicsLayer.cc:96: {
> "
> 
>
https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/PhysicsLayer.h
> File nacltoons/src/PhysicsLayer.h (right):
> 
>
https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/PhysicsLayer...
> nacltoons/src/PhysicsLayer.h:16: {
> { on previous line

I think we should use google style except where directly interacting
with cococs.  I'll the changes you suggest.

[Sam Clegg, 2013-02-12 23:07:38]

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/AppDelegate.cc
File nacltoons/src/AppDelegate.cc (right):

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/AppDelegate....
nacltoons/src/AppDelegate.cc:1: // Copyright (c) 2013 The Native Client Authors.
All rights reserved.
On 2013/02/12 22:51:53, binji wrote:
> some of these are Native Client and some are Chromium. Which do we want?

Done.

We'll go with Chromium Authors to match the rest of
the code in this repo.

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/FrontEnd.cc
File nacltoons/src/FrontEnd.cc (right):

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/FrontEnd.cc#...
nacltoons/src/FrontEnd.cc:15: 
On 2013/02/12 22:51:53, binji wrote:
> nit: one space here and below

Done

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/FrontEnd.cc#...
nacltoons/src/FrontEnd.cc:39: CCMenuItemLabel* start =
CCMenuItemLabel::create(start_label,
On 2013/02/12 22:51:53, binji wrote:
> nit: move start_label to next line, or wrap the following line starting at (

Done.

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/FrontEnd.h
File nacltoons/src/FrontEnd.h (right):

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/FrontEnd.h#n...
nacltoons/src/FrontEnd.h:15: {
On 2013/02/12 22:51:53, binji wrote:
> nit: { on previous line

Done.

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/GameplayScene.h
File nacltoons/src/GameplayScene.h (right):

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/GameplayScen...
nacltoons/src/GameplayScene.h:17: {
On 2013/02/12 22:51:53, binji wrote:
> nit: { on previous line

Done.

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/GameplayScen...
nacltoons/src/GameplayScene.h:31: {
On 2013/02/12 22:51:53, binji wrote:
> nit: { on previous line

Done.

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/PhysicsLayer.cc
File nacltoons/src/PhysicsLayer.cc (right):

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/PhysicsLayer...
nacltoons/src/PhysicsLayer.cc:26: CCSpriteBatchNode* batch =
CCSpriteBatchNode::create("blocks.png", 100);
On 2013/02/12 22:51:53, binji wrote:
> magic number?

Done.

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/PhysicsLayer...
nacltoons/src/PhysicsLayer.cc:39: {
On 2013/02/12 22:51:53, binji wrote:
> { on previous line

Done.

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/PhysicsLayer...
nacltoons/src/PhysicsLayer.cc:45: {
On 2013/02/12 22:51:53, binji wrote:
> { on previous line

Done.

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/PhysicsLayer...
nacltoons/src/PhysicsLayer.cc:84: {
On 2013/02/12 22:51:53, binji wrote:
> "

Done.

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/PhysicsLayer...
nacltoons/src/PhysicsLayer.cc:96: {
On 2013/02/12 22:51:53, binji wrote:
> "

Done.

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/PhysicsLayer.h
File nacltoons/src/PhysicsLayer.h (right):

https://codereview.chromium.org/12226130/diff/6001/nacltoons/src/PhysicsLayer...
nacltoons/src/PhysicsLayer.h:16: {
On 2013/02/12 22:51:53, binji wrote:
> { on previous line

Done.

[binji, 2013-02-12 23:13:25]

don't forget filenames should be lower_case not MixedCase

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/FrontEnd.h
File nacltoons/src/FrontEnd.h (right):

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/FrontEnd.h#...
nacltoons/src/FrontEnd.h:4: #ifndef FRONTEND_H
FRONTEND_H_

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/FrontEnd.h#...
nacltoons/src/FrontEnd.h:24: virtual void startGame(CCObject* sender);
Is this defined in CCLayerColor or below? If not, "StartGame"

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/FrontEnd.h#...
nacltoons/src/FrontEnd.h:24: virtual void startGame(CCObject* sender);
does this need to be virtual?

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/GameplaySce...
File nacltoons/src/GameplayScene.h (right):

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/GameplaySce...
nacltoons/src/GameplayScene.h:38: virtual void restart(CCObject* sender);
Restart

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/GameplaySce...
nacltoons/src/GameplayScene.h:38: virtual void restart(CCObject* sender);
Do these need to be virtual?

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/GameplaySce...
nacltoons/src/GameplayScene.h:39: virtual void exit(CCObject* sender);
Exit

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/PhysicsLayer.h
File nacltoons/src/PhysicsLayer.h (right):

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/PhysicsLaye...
nacltoons/src/PhysicsLayer.h:24: void addNewSpriteAtPosition(CCPoint p);
MixedCase these three

[Sam Clegg, 2013-02-12 23:22:36]

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/FrontEnd.h
File nacltoons/src/FrontEnd.h (right):

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/FrontEnd.h#...
nacltoons/src/FrontEnd.h:4: #ifndef FRONTEND_H
On 2013/02/12 23:13:25, binji wrote:
> FRONTEND_H_

Done.

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/FrontEnd.h#...
nacltoons/src/FrontEnd.h:24: virtual void startGame(CCObject* sender);
On 2013/02/12 23:13:25, binji wrote:
> Is this defined in CCLayerColor or below? If not, "StartGame"

Done.

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/FrontEnd.h#...
nacltoons/src/FrontEnd.h:24: virtual void startGame(CCObject* sender);
On 2013/02/12 23:13:25, binji wrote:
> does this need to be virtual?

Done.

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/GameplaySce...
File nacltoons/src/GameplayScene.h (right):

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/GameplaySce...
nacltoons/src/GameplayScene.h:38: virtual void restart(CCObject* sender);
On 2013/02/12 23:13:25, binji wrote:
> Restart

Done.

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/GameplaySce...
nacltoons/src/GameplayScene.h:38: virtual void restart(CCObject* sender);
On 2013/02/12 23:13:25, binji wrote:
> Do these need to be virtual?

Done.

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/GameplaySce...
nacltoons/src/GameplayScene.h:39: virtual void exit(CCObject* sender);
On 2013/02/12 23:13:25, binji wrote:
> Exit

Done.

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/PhysicsLayer.h
File nacltoons/src/PhysicsLayer.h (right):

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/PhysicsLaye...
nacltoons/src/PhysicsLayer.h:24: void addNewSpriteAtPosition(CCPoint p);
On 2013/02/12 23:13:25, binji wrote:
> MixedCase these three

Done.

[binji, 2013-02-12 23:25:34]

This got lost in the previous comments:

don't forget filenames should be lower_case not MixedCase


other than that, lgtm

[noelallen1, 2013-02-12 23:35:52]

lgtm

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/FrontEnd.cc
File nacltoons/src/FrontEnd.cc (right):

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/FrontEnd.cc...
nacltoons/src/FrontEnd.cc:9: CCScene* FrontEnd::scene() {
CreateScene() - otherwise this looks like an accessor, and I wouldn't know it
was creating again and again.

Could you add comments, so we know the use theory?

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/FrontEnd.cc...
nacltoons/src/FrontEnd.cc:11: CCLayer* frontend = FrontEnd::create();
Are you instantiating something then throwing it away?

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/FrontEnd.cc...
nacltoons/src/FrontEnd.cc:13: return scene;
Is a Layer a collection of Scenes or a Scene a collection of layers?

You are adding FrontEnd a Layer to the scene.

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/FrontEnd.h
File nacltoons/src/FrontEnd.h (right):

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/FrontEnd.h#...
nacltoons/src/FrontEnd.h:12: * Front end scene and layer.
Don't self reference in your doc.  Tell us what this object is supposed to do.

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/FrontEnd.h#...
nacltoons/src/FrontEnd.h:18: CREATE_FUNC(FrontEnd);
What is this macro for?

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/FrontEnd.h#...
nacltoons/src/FrontEnd.h:27: #endif // !FRONTEND_H
!FRONTEND_H, did you mean to add the !
I think the standard check is:
#endif  // NAME
with a double space between endif and single space after //
There used to be a presubmit check for this I think.

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/GameplaySce...
File nacltoons/src/GameplayScene.cc (right):

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/GameplaySce...
nacltoons/src/GameplayScene.cc:7: #define PHYSICS_TAG 101
Are these IDs global?  Meaning we don't when them to ever collide?  Should you
use a separate .h with enums?

Maybe provide some allocation pool for LUA instantiated objects that need IDs?

Otherwise "const int" can be evaluated by the debugger, #define can not.

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/GameplaySce...
nacltoons/src/GameplayScene.cc:13: return Gameplay::create();
Is there a reason that "scene" in this one returns create, while "scene" in
front end does the create work?

https://codereview.chromium.org/12226130/diff/10001/nacltoons/src/GameplaySce...
nacltoons/src/GameplayScene.cc:37: ((Gameplay*)getParent())->restart();
static_cast<Gameplay*>(getParent())->