Issue 12223046: Use generated actual decoders for ARM table:

Issue 12223046: Use generated actual decoders for ARM table: (Closed)

Created:
7 years, 10 months ago by Karl

Modified:
7 years, 10 months ago

Reviewers:
JF

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client/

Visibility:
Public.

More Reviews

Description

Use generated actual decoders for ARM table: branch_branch_with_link_and_block_data_transfer BUG= http://code.google.com/p/nativeclient/issues/detail?id=3111 TEST= ./scons platform=arm \ run_arm32_decode_branch_branch_with_link_and_block_data_transfer_tests Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=10761

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+399 lines, -207 lines)			Patch
M	src/trusted/validator_arm/armv7.table	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/trusted/validator_arm/build.scons	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/trusted/validator_arm/gen/arm32_decode.h	View	1	5 chunks	+4 lines, -3 lines	0 comments	Download
M	src/trusted/validator_arm/gen/arm32_decode.cc	View	1	7 chunks	+14 lines, -8 lines	0 comments	Download
M	src/trusted/validator_arm/gen/arm32_decode_actuals_1.h	View	1	23 chunks	+24 lines, -22 lines	0 comments	Download
M	src/trusted/validator_arm/gen/arm32_decode_actuals_1.cc	View	1	8 chunks	+14 lines, -12 lines	0 comments	Download
M	src/trusted/validator_arm/gen/arm32_decode_baselines_1.h	View	1	12 chunks	+12 lines, -10 lines	0 comments	Download
M	src/trusted/validator_arm/gen/arm32_decode_baselines_1.cc	View	1	18 chunks	+28 lines, -22 lines	0 comments	Download
M	src/trusted/validator_arm/gen/arm32_decode_baselines_2.h	View	1	8 chunks	+8 lines, -8 lines	0 comments	Download
M	src/trusted/validator_arm/gen/arm32_decode_baselines_2.cc	View	1	12 chunks	+20 lines, -16 lines	0 comments	Download
M	src/trusted/validator_arm/gen/arm32_decode_branch_branch_with_link_and_block_data_transfer_tests.cc	View	1	59 chunks	+100 lines, -104 lines	0 comments	Download
M	src/trusted/validator_arm/gen/arm32_decode_named_classes.h	View	1	6 chunks	+160 lines, -0 lines	0 comments	Download
M	src/trusted/validator_arm/gen/arm32_decode_named_decoder.h	View	1	3 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

lgtm after comment change. https://codereview.chromium.org/12223046/diff/1/src/trusted/validator_arm/armv7.table File src/trusted/validator_arm/armv7.table (right): https://codereview.chromium.org/12223046/diff/1/src/trusted/validator_arm/armv7.table#newcode1806 src/trusted/validator_arm/armv7.table:1806: relative_offset := imm32 + 8; ...

7 years, 10 months ago (2013-02-11 19:40:38 UTC) #2

Karl

7 years, 10 months ago (2013-02-11 22:12:43 UTC) #3

https://codereview.chromium.org/12223046/diff/1/src/trusted/validator_arm/arm...
File src/trusted/validator_arm/armv7.table (right):

https://codereview.chromium.org/12223046/diff/1/src/trusted/validator_arm/arm...
src/trusted/validator_arm/armv7.table:1806: relative_offset := imm32 + 8;  # r15
is 8 bytes ahead of instruction address.
On 2013/02/11 19:40:38, JF wrote:
> I'd change the comment to be the same as other places in the code that do
this:
> 
> The ARM manual states that "PC reads as the address of the current instruction
> plus 8".

Done.

Expand Messages | Collapse Messages