|
Add a flag showing whether the current request was ignored by a handler
When converting to using a resource throttle to call
shouldOverrideUrlLoading in WebView we need to know whether the current
request was ignored because of shouldOverrideUrlLoading or something
else. This is because we need to know when to post OnPageFinished.
This is an initial CL that simply passes the flag where it needs to be
-- the actual move to using a resource throttle will be added in a
follow-up CL to make that CL more easily reviewable/updatable.
The flag is passed down from
WebURLLoaderImpl::Context::OnCompletedRequest in
content/child/web_url_loader_impl.cc all the way to
AwWebContentsObserver.didFailLoad so that we can make the right decision
there. A large part of the flag-passing is handled through adding a flag
to WebURLError and ResourceError in Blink:
https://codereview.chromium.org/1178273007/
TBR=jochen@chromium.org,fsamuel@chromium.org
BUG= 325351
Committed: https://crrev.com/6fbb38696709063437ffeccad69b34de401c55c6
Cr-Commit-Position: refs/heads/master@{#335974}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+194 lines, -100 lines) |
Patch |
|
M |
android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/android/java/src/org/chromium/chrome/browser/Tab.java
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/android/java/src/org/chromium/chrome/browser/tab/BackgroundContentViewHelper.java
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/android/java_staging/src/org/chromium/chrome/browser/tab/ChromeTab.java
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/after_startup_task_utils.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/captive_portal/captive_portal_tab_helper.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/captive_portal/captive_portal_tab_helper.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc
|
View
|
1
|
10 chunks |
+23 lines, -14 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/first_run/drive_first_run_controller.cc
|
View
|
|
3 chunks |
+8 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/login/ui/webui_login_view.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/login/ui/webui_login_view.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/errorpage_browsertest.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/identity/web_auth_flow.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/identity/web_auth_flow.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/web_navigation/web_navigation_api.h
|
View
|
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
|
View
|
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/net/net_error_tab_helper.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/net/net_error_tab_helper.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/net/net_error_tab_helper_unittest.cc
|
View
|
1
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ssl/ssl_browser_tests.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/omnibox/omnibox_navigation_observer.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/omnibox/omnibox_navigation_observer.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/chromeos/mobile_setup_ui.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/test/base/in_process_browser_test_browsertest.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
components/dom_distiller/content/distiller_page_web_contents.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
components/dom_distiller/content/distiller_page_web_contents.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
content/browser/android/web_contents_observer_proxy.h
|
View
|
|
2 chunks |
+6 lines, -3 lines |
0 comments
|
Download
|
|
M |
content/browser/android/web_contents_observer_proxy.cc
|
View
|
|
3 chunks |
+10 lines, -6 lines |
0 comments
|
Download
|
|
M |
content/browser/devtools/render_frame_devtools_agent_host.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
content/browser/devtools/render_frame_devtools_agent_host.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
content/browser/frame_host/navigation_controller_impl_browsertest.cc
|
View
|
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/browser/frame_host/navigator.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
content/browser/frame_host/navigator_delegate.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
content/browser/frame_host/navigator_impl.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
content/browser/frame_host/navigator_impl.cc
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/browser/frame_host/render_frame_host_impl.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
content/browser/frame_host/render_frame_host_impl.cc
|
View
|
|
1 chunk |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/browser/web_contents/web_contents_impl.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
content/browser/web_contents/web_contents_impl.cc
|
View
|
|
2 chunks |
+6 lines, -3 lines |
0 comments
|
Download
|
|
M |
content/browser/web_contents/web_contents_impl_unittest.cc
|
View
|
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/child/web_url_loader_impl.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
content/child/web_url_request_util.h
|
View
|
|
1 chunk |
+6 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/child/web_url_request_util.cc
|
View
|
|
1 chunk |
+10 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/common/frame_messages.h
|
View
|
|
2 chunks |
+6 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
content/public/android/java/src/org/chromium/content_public/browser/WebContentsObserver.java
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
content/public/browser/web_contents_observer.h
|
View
|
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestWebContentsObserver.java
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/public/test/test_navigation_observer.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
content/renderer/render_frame_impl.cc
|
View
|
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
content/test/test_web_contents.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
content/test/test_web_contents.cc
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/test/web_contents_observer_sanity_checker.h
|
View
|
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/test/web_contents_observer_sanity_checker.cc
|
View
|
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
extensions/browser/guest_view/web_view/web_view_guest.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
extensions/browser/guest_view/web_view/web_view_guest.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
Total messages: 24 (9 generated)
|