chrome/browser/captive_portal/captive_portal_tab_helper.h - Issue 1194383003: Add a flag showing whether the current request was ignored by a handler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/captive_portal/captive_portal_tab_helper.h

Issue 1194383003: Add a flag showing whether the current request was ignored by a handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix trybot failures (DidFailProvisionalLoad calls in unit tests) Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/captive_portal/captive_portal_tab_helper.h

diff --git a/chrome/browser/captive_portal/captive_portal_tab_helper.h b/chrome/browser/captive_portal/captive_portal_tab_helper.h

index efb0fbbeb8dc5d15b2fdb51c7be47b52c97b0d54..630ce095436a633b677fdecd0c09c45817be62c3 100644

--- a/chrome/browser/captive_portal/captive_portal_tab_helper.h

+++ b/chrome/browser/captive_portal/captive_portal_tab_helper.h

@@ -79,7 +79,8 @@ class CaptivePortalTabHelper

void DidFailProvisionalLoad(content::RenderFrameHost* render_frame_host,

const GURL& validated_url,

int error_code,

- const base::string16& error_description) override;

+ const base::string16& error_description,

+ bool was_ignored_by_handler) override;

void DidStopLoading() override;

« no previous file with comments | « chrome/browser/after_startup_task_utils.cc ('k') | chrome/browser/captive_portal/captive_portal_tab_helper.cc » ('j') | no next file with comments »