Add a flag showing whether the current request was ignored by a handler

chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/captive_portal/captive_portal_tab_helper.h"
 
 #include "base/callback.h"
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/captive_portal/captive_portal_service.h"
 #include "chrome/browser/captive_portal/captive_portal_tab_reloader.h"
@@ skipping 101 matching lines @@
   void SimulateTimeout(const GURL& url,
                        content::RenderViewHost* render_view_host) {
     EXPECT_CALL(mock_reloader(), OnLoadStart(url.SchemeIsCryptographic()))
         .Times(1);
     tab_helper().DidStartProvisionalLoadForFrame(
         render_view_host->GetMainFrame(), url, false, false);
 
     tab_helper().DidFailProvisionalLoad(render_view_host->GetMainFrame(),
                                         url,
                                         net::ERR_TIMED_OUT,
-                                        base::string16());
+                                        base::string16(),
+                                        false);
 
     // Provisional load starts for the error page.
     tab_helper().DidStartProvisionalLoadForFrame(
         render_view_host->GetMainFrame(), GURL(kErrorPageUrl), true, false);
 
     EXPECT_CALL(mock_reloader(), OnLoadCommitted(net::ERR_TIMED_OUT)).Times(1);
     tab_helper().DidCommitProvisionalLoadForFrame(
         render_view_host->GetMainFrame(),
         GURL(kErrorPageUrl),
         ui::PAGE_TRANSITION_LINK);
   }
 
   // Simulates an abort while requesting |url|.
   void SimulateAbort(const GURL& url,
                      content::RenderViewHost* render_view_host,
                      NavigationType navigation_type) {
     EXPECT_CALL(mock_reloader(), OnLoadStart(url.SchemeIsCryptographic()))
         .Times(1);
     tab_helper().DidStartProvisionalLoadForFrame(
         render_view_host->GetMainFrame(), url, false, false);
 
     EXPECT_CALL(mock_reloader(), OnAbort()).Times(1);
     if (navigation_type == kSameProcess) {
       tab_helper().DidFailProvisionalLoad(render_view_host->GetMainFrame(),
                                           url,
                                           net::ERR_ABORTED,
-                                          base::string16());
+                                          base::string16(),
+                                          false);
     } else {
       // For interrupted provisional cross-process navigations, the
       // RenderViewHost is destroyed without sending a DidFailProvisionalLoad
       // notification.
       tab_helper().RenderViewDeleted(render_view_host);
     }
 
     // Make sure that above call resulted in abort, for tests that continue
     // after the abort.
     EXPECT_CALL(mock_reloader(), OnAbort()).Times(0);
   }
 
   // Simulates an abort while loading an error page.
   void SimulateAbortTimeout(const GURL& url,
                             content::RenderViewHost* render_view_host,
                             NavigationType navigation_type) {
     EXPECT_CALL(mock_reloader(), OnLoadStart(url.SchemeIsCryptographic()))
         .Times(1);
     tab_helper().DidStartProvisionalLoadForFrame(
         render_view_host->GetMainFrame(), url, false, false);
 
     tab_helper().DidFailProvisionalLoad(render_view_host->GetMainFrame(),
                                         url,
                                         net::ERR_TIMED_OUT,
-                                        base::string16());
+                                        base::string16(),
+                                        false);
 
     // Start event for the error page.
     tab_helper().DidStartProvisionalLoadForFrame(
         render_view_host->GetMainFrame(), url, true, false);
 
     EXPECT_CALL(mock_reloader(), OnAbort()).Times(1);
     if (navigation_type == kSameProcess) {
       tab_helper().DidFailProvisionalLoad(render_view_host->GetMainFrame(),
                                           url,
                                           net::ERR_ABORTED,
-                                          base::string16());
+                                          base::string16(),
+                                          false);
     } else {
       // For interrupted provisional cross-process navigations, the
       // RenderViewHost is destroyed without sending a DidFailProvisionalLoad
       // notification.
       tab_helper().RenderViewDeleted(render_view_host);
     }
 
     // Make sure that above call resulted in abort, for tests that continue
     // after the abort.
     EXPECT_CALL(mock_reloader(), OnAbort()).Times(0);
@@ skipping 161 matching lines @@
   EXPECT_CALL(mock_reloader(), OnAbort()).Times(1);
   EXPECT_CALL(mock_reloader(),
               OnLoadStart(cross_process_url.SchemeIsCryptographic())).Times(1);
   tab_helper().DidStartProvisionalLoadForFrame(
       main_render_frame2(), cross_process_url, false, false);
 
   // The cross-process navigation fails.
   tab_helper().DidFailProvisionalLoad(main_render_frame2(),
                                       cross_process_url,
                                       net::ERR_FAILED,
-                                      base::string16());
+                                      base::string16(),
+                                      false);
 
   // The same-site navigation finally is aborted.
   tab_helper().DidFailProvisionalLoad(main_render_frame1(),
                                       same_site_url,
                                       net::ERR_ABORTED,
-                                      base::string16());
+                                      base::string16(),
+                                      false);
 
   // The provisional load starts for the error page for the cross-process
   // navigation.
   tab_helper().DidStartProvisionalLoadForFrame(
       main_render_frame2(), GURL(kErrorPageUrl), true, false);
 
   EXPECT_CALL(mock_reloader(), OnLoadCommitted(net::ERR_FAILED)).Times(1);
   tab_helper().DidCommitProvisionalLoadForFrame(main_render_frame2(),
                                                 GURL(kErrorPageUrl),
                                                 ui::PAGE_TRANSITION_TYPED);
@@ skipping 17 matching lines @@
   EXPECT_CALL(mock_reloader(), OnAbort()).Times(1);
   EXPECT_CALL(mock_reloader(),
               OnLoadStart(cross_process_url.SchemeIsCryptographic())).Times(1);
   tab_helper().DidStartProvisionalLoadForFrame(
       main_render_frame2(), cross_process_url, false, false);
 
   // The cross-process navigation fails.
   tab_helper().DidFailProvisionalLoad(main_render_frame2(),
                                       cross_process_url,
                                       net::ERR_FAILED,
-                                      base::string16());
+                                      base::string16(),
+                                      false);
 
   // The same-site navigation succeeds.
   EXPECT_CALL(mock_reloader(), OnAbort()).Times(1);
   EXPECT_CALL(mock_reloader(),
               OnLoadStart(same_site_url.SchemeIsCryptographic())).Times(1);
   EXPECT_CALL(mock_reloader(), OnLoadCommitted(net::OK)).Times(1);
   tab_helper().DidCommitProvisionalLoadForFrame(
       main_render_frame1(), same_site_url, ui::PAGE_TRANSITION_LINK);
 }
 
@@ skipping 10 matching lines @@
   // Normal load.
   tab_helper().DidStartProvisionalLoadForFrame(subframe1, url, false, false);
   tab_helper().DidCommitProvisionalLoadForFrame(
       subframe1, url, ui::PAGE_TRANSITION_LINK);
 
   // Timeout.
   content::RenderFrameHost* subframe2 =
       render_frame_host_tester->AppendChild("subframe2");
   tab_helper().DidStartProvisionalLoadForFrame(subframe2, url, false, false);
   tab_helper().DidFailProvisionalLoad(
-      subframe2, url, net::ERR_TIMED_OUT, base::string16());
+      subframe2, url, net::ERR_TIMED_OUT, base::string16(), false);
   tab_helper().DidStartProvisionalLoadForFrame(subframe2, url, true, false);
   tab_helper().DidFailProvisionalLoad(
-      subframe2, url, net::ERR_ABORTED, base::string16());
+      subframe2, url, net::ERR_ABORTED, base::string16(), false);
 
   // Abort.
   content::RenderFrameHost* subframe3 =
       render_frame_host_tester->AppendChild("subframe3");
   tab_helper().DidStartProvisionalLoadForFrame(subframe3, url, false, false);
   tab_helper().DidFailProvisionalLoad(
-      subframe3, url, net::ERR_ABORTED, base::string16());
+      subframe3, url, net::ERR_ABORTED, base::string16(), false);
 }
 
 // Simulates a subframe erroring out at the same time as a provisional load,
 // but with a different error code.  Make sure the TabHelper sees the correct
 // error.
 TEST_F(CaptivePortalTabHelperTest, HttpsSubframeParallelError) {
   // URL used by both frames.
   GURL url = GURL(kHttpsUrl);
   content::RenderFrameHost* subframe =
       content::RenderFrameHostTester::For(main_render_frame1())
           ->AppendChild("subframe");
 
   // Loads start.
   EXPECT_CALL(mock_reloader(), OnLoadStart(url.SchemeIsCryptographic()))
       .Times(1);
   tab_helper().DidStartProvisionalLoadForFrame(
       main_render_frame1(), url, false, false);
   tab_helper().DidStartProvisionalLoadForFrame(subframe, url, false, false);
 
   // Loads return errors.
   tab_helper().DidFailProvisionalLoad(
-      main_render_frame1(), url, net::ERR_UNEXPECTED, base::string16());
+      main_render_frame1(), url, net::ERR_UNEXPECTED, base::string16(), false);
   tab_helper().DidFailProvisionalLoad(
-      subframe, url, net::ERR_TIMED_OUT, base::string16());
+      subframe, url, net::ERR_TIMED_OUT, base::string16(), false);
 
   // Provisional load starts for the error pages.
   tab_helper().DidStartProvisionalLoadForFrame(
       main_render_frame1(), url, true, false);
   tab_helper().DidStartProvisionalLoadForFrame(subframe, url, true, false);
 
   // Error page load finishes.
   tab_helper().DidCommitProvisionalLoadForFrame(
       subframe, url, ui::PAGE_TRANSITION_AUTO_SUBFRAME);
   EXPECT_CALL(mock_reloader(), OnLoadCommitted(net::ERR_UNEXPECTED)).Times(1);
@@ skipping 10 matching lines @@
 
   GURL https_url(kHttpsUrl);
   EXPECT_CALL(mock_reloader(), OnRedirect(true)).Times(1);
   OnRedirect(content::RESOURCE_TYPE_MAIN_FRAME,
              https_url,
              render_view_host1()->GetProcess()->GetID());
 
   tab_helper().DidFailProvisionalLoad(main_render_frame1(),
                                       https_url,
                                       net::ERR_TIMED_OUT,
-                                      base::string16());
+                                      base::string16(),
+                                      false);
 
   // Provisional load starts for the error page.
   tab_helper().DidStartProvisionalLoadForFrame(
       main_render_frame1(), GURL(kErrorPageUrl), true, false);
 
   EXPECT_CALL(mock_reloader(), OnLoadCommitted(net::ERR_TIMED_OUT)).Times(1);
   tab_helper().DidCommitProvisionalLoadForFrame(main_render_frame1(),
                                                 GURL(kErrorPageUrl),
                                                 ui::PAGE_TRANSITION_LINK);
 }
@@ skipping 63 matching lines @@
   // Another RenderViewHost sees a redirect.  None of the reloader's functions
   // should be called.
   GURL https_url(kHttpsUrl);
   OnRedirect(content::RESOURCE_TYPE_MAIN_FRAME,
              https_url,
              render_view_host2()->GetProcess()->GetID());
 
   tab_helper().DidFailProvisionalLoad(main_render_frame1(),
                                       https_url,
                                       net::ERR_TIMED_OUT,
-                                      base::string16());
+                                      base::string16(),
+                                      false);
 
   // Provisional load starts for the error page.
   tab_helper().DidStartProvisionalLoadForFrame(
       main_render_frame1(), GURL(kErrorPageUrl), true, false);
 
   EXPECT_CALL(mock_reloader(), OnLoadCommitted(net::ERR_TIMED_OUT)).Times(1);
   tab_helper().DidCommitProvisionalLoadForFrame(main_render_frame1(),
                                                 GURL(kErrorPageUrl),
                                                 ui::PAGE_TRANSITION_LINK);
 }
@@ skipping 46 matching lines @@
   EXPECT_FALSE(tab_helper().IsLoginTab());
 
   ObservePortalResult(captive_portal::RESULT_BEHIND_CAPTIVE_PORTAL,
                       captive_portal::RESULT_NO_RESPONSE);
   EXPECT_FALSE(tab_helper().IsLoginTab());
 
   ObservePortalResult(captive_portal::RESULT_NO_RESPONSE,
                       captive_portal::RESULT_INTERNET_CONNECTED);
   EXPECT_FALSE(tab_helper().IsLoginTab());
 }