Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1178273007: Add a flag for when a navigation is ignored (e.g. by shouldOverrideUrl). (Closed)

Created:
5 years, 6 months ago by gsennton
Modified:
5 years, 6 months ago
Reviewers:
Nate Chapin, dglazkov
CC:
blink-reviews, dglazkov+blink, sgurun-gerrit only
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add a flag for when a navigation is ignored (e.g. by shouldOverrideUrl). When moving to using a resource throttle for shouldOverrideUrlLoading in webview we need to know whether a failed navigation was caused by shouldOverrideUrlLoading. The following CL depends on this CL https://codereview.chromium.org/1155713005 BUG=325351 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197578

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M Source/platform/exported/WebURLError.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/platform/network/ResourceError.h View 4 chunks +6 lines, -0 lines 0 comments Download
M Source/platform/network/ResourceError.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M public/platform/WebURLError.h View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 13 (3 generated)
gsennton
Hi, I am trying to use a resource throttle to implement a function called shouldOverrideUrlLoading ...
5 years, 6 months ago (2015-06-17 16:56:34 UTC) #2
dglazkov
On 2015/06/17 at 16:56:34, gsennton wrote: > Hi, I am trying to use a resource ...
5 years, 6 months ago (2015-06-17 20:19:57 UTC) #4
Nate Chapin
On 2015/06/17 20:19:57, dglazkov wrote: > On 2015/06/17 at 16:56:34, gsennton wrote: > > Hi, ...
5 years, 6 months ago (2015-06-17 20:53:30 UTC) #5
gsennton
On 2015/06/17 20:53:30, Nate Chapin wrote: > On 2015/06/17 20:19:57, dglazkov wrote: > > On ...
5 years, 6 months ago (2015-06-18 13:55:46 UTC) #6
gsennton
On 2015/06/18 13:55:46, gsennton wrote: > On 2015/06/17 20:53:30, Nate Chapin wrote: > > On ...
5 years, 6 months ago (2015-06-19 16:49:30 UTC) #7
Nate Chapin
This may be a case where in a perfect world it'd be an error code, ...
5 years, 6 months ago (2015-06-19 18:57:31 UTC) #8
gsennton
On 2015/06/19 18:57:31, Nate Chapin wrote: > This may be a case where in a ...
5 years, 6 months ago (2015-06-22 12:50:10 UTC) #9
dglazkov
lgtm
5 years, 6 months ago (2015-06-22 13:58:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178273007/1
5 years, 6 months ago (2015-06-22 14:03:38 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 15:08:31 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197578

Powered by Google App Engine
This is Rietveld 408576698