chrome/browser/extensions/api/web_navigation/web_navigation_api.cc - Issue 1194383003: Add a flag showing whether the current request was ignored by a handler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

Issue 1194383003: Add a flag showing whether the current request was ignored by a handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix trybot failures (DidFailProvisionalLoad calls in unit tests) Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_navigation/web_navigation_api.h ('k') | chrome/browser/net/net_error_tab_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

index d5a9dda60d5eb8b242c75b87cad0ba321f436833..83ca7e004670b27d3af4583b1ea24fba458fcc40 100644

--- a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

@@ -340,7 +340,8 @@ void WebNavigationTabObserver::DidFailProvisionalLoad(

content::RenderFrameHost* render_frame_host,

const GURL& validated_url,

int error_code,

- const base::string16& error_description) {

+ const base::string16& error_description,

+ bool was_ignored_by_handler) {

DVLOG(2) << "DidFailProvisionalLoad("

<< "render_frame_host=" << render_frame_host

<< ", frame_num=" << render_frame_host->GetRoutingID()

@@ -414,7 +415,8 @@ void WebNavigationTabObserver::DidFailLoad(