chrome/browser/extensions/api/web_navigation/web_navigation_api.h - Issue 1194383003: Add a flag showing whether the current request was ignored by a handler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.h

Issue 1194383003: Add a flag showing whether the current request was ignored by a handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix trybot failures (DidFailProvisionalLoad calls in unit tests) Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/identity/web_auth_flow.cc ('k') | chrome/browser/extensions/api/web_navigation/web_navigation_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_navigation/web_navigation_api.h

diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api.h b/chrome/browser/extensions/api/web_navigation/web_navigation_api.h

index b2ab0c25b91e5004d7374dad684c8b551b934589..74c43aa0ce8f10f7b65d9cadc36528b2dcfdf5da 100644

--- a/chrome/browser/extensions/api/web_navigation/web_navigation_api.h

+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api.h

@@ -60,7 +60,8 @@ class WebNavigationTabObserver

void DidFailProvisionalLoad(content::RenderFrameHost* render_frame_host,

const GURL& validated_url,

int error_code,

- const base::string16& error_description) override;

+ const base::string16& error_description,

+ bool was_ignored_by_handler) override;

void DocumentLoadedInFrame(

content::RenderFrameHost* render_frame_host) override;

void DidFinishLoad(content::RenderFrameHost* render_frame_host,

@@ -68,7 +69,8 @@ class WebNavigationTabObserver

void DidFailLoad(content::RenderFrameHost* render_frame_host,

const GURL& validated_url,

int error_code,

- const base::string16& error_description) override;

+ const base::string16& error_description,

+ bool was_ignored_by_handler) override;

void DidGetRedirectForResourceRequest(

content::RenderFrameHost* render_frame_host,

const content::ResourceRedirectDetails& details) override;