Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1188223002: Improved subset benchmarks (Closed)

Created:
5 years, 6 months ago by msarett
Modified:
4 years, 11 months ago
Reviewers:
scroggo, emmaleer, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Improved subset benchmarks I think these changes to the subset benchmarks cover what we discussed yesterday. I removed the divisor benchmarks (2x2, 3x3) and changed the single subset benchmarks. Also, we will no longer benchmark subset decodes on small images. BUG=skia: Committed: https://skia.googlesource.com/skia/+/ab80e35fbddd5b534b486cf9d331b5da00e5aa4f GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1188223002

Patch Set 1 #

Patch Set 2 : Remove unwanted images in Gold caused by CodecSrc dm reorganization #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M src/codec/SkCodec.cpp View 1 2 3 4 1 chunk +1 line, -10 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
msarett
I think these changes to the subset benchmarks cover what we discussed yesterday. I removed ...
5 years, 6 months ago (2015-06-17 12:20:01 UTC) #2
scroggo
On 2015/06/17 12:20:01, msarett wrote: > I think these changes to the subset benchmarks cover ...
5 years, 6 months ago (2015-06-17 15:49:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1188223002/1
5 years, 6 months ago (2015-06-17 17:22:41 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 17:28:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ab80e35fbddd5b534b486cf9d331b5da00e5aa4f

Powered by Google App Engine
This is Rietveld 408576698