NEON optimizations for gray -> RGBA (or BGRA) conversions

NEON optimizations for gray -> RGBA (or BGRA) conversions

Swizzle Bench Runtime
Nexus 6P 0.32x
Nexus 9  0.89x

PNG Decode Time (for test set of gray encoded PNGs)
Nexus 6P 0.88x
Nexus 9  0.91x

BUG=skia:4767
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1656383002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed: https://skia.googlesource.com/skia/+/2eff71c9b5f984b58961e5a6b4e66774c4385224

[msarett, 2016-02-02 19:06:38]

Description was changed from

==========
NEON optimizations for gray -> RGBA (or BGRA) conversions

Swizzle Bench Runtime
Nexus 6P 0.32x
Nexus 9  0.89x

PNG Decode Time (for test set of gray encoded PNGs)
Nexus 6P 0.88x
Nexus 9  0.91x

BUG=skia:4767
==========

to

==========
NEON optimizations for gray -> RGBA (or BGRA) conversions

Swizzle Bench Runtime
Nexus 6P 0.32x
Nexus 9  0.89x

PNG Decode Time (for test set of gray encoded PNGs)
Nexus 6P 0.88x
Nexus 9  0.91x

BUG=skia:4767
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[msarett, 2016-02-02 19:07:21]

msarett@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-02-02 19:34:59]

lgtm

Just nits about comments.
SSE next?

https://codereview.chromium.org/1656383002/diff/20001/src/codec/SkSwizzler.cpp
File src/codec/SkSwizzler.cpp (right):

https://codereview.chromium.org/1656383002/diff/20001/src/codec/SkSwizzler.cp...
src/codec/SkSwizzler.cpp:281: // Note that we there is no need to distinguish
between RGB and BGR.
I think, remove the word "we"?

https://codereview.chromium.org/1656383002/diff/20001/src/opts/SkSwizzler_opts.h
File src/opts/SkSwizzler_opts.h (right):

https://codereview.chromium.org/1656383002/diff/20001/src/opts/SkSwizzler_opt...
src/opts/SkSwizzler_opts.h:304: // Store 16 pixels.
16 -> 8

[msarett, 2016-02-02 20:10:28]

Yes SSE is coming very soon.

https://codereview.chromium.org/1656383002/diff/20001/src/codec/SkSwizzler.cpp
File src/codec/SkSwizzler.cpp (right):

https://codereview.chromium.org/1656383002/diff/20001/src/codec/SkSwizzler.cp...
src/codec/SkSwizzler.cpp:281: // Note that we there is no need to distinguish
between RGB and BGR.
On 2016/02/02 19:34:59, mtklein wrote:
> I think, remove the word "we"?

Done.

https://codereview.chromium.org/1656383002/diff/20001/src/opts/SkSwizzler_opts.h
File src/opts/SkSwizzler_opts.h (right):

https://codereview.chromium.org/1656383002/diff/20001/src/opts/SkSwizzler_opt...
src/opts/SkSwizzler_opts.h:304: // Store 16 pixels.
On 2016/02/02 19:34:59, mtklein wrote:
> 16 -> 8

Done.

[msarett, 2016-02-02 20:10:54]

The CQ bit was checked by msarett@google.com

[msarett, 2016-02-02 20:10:55]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1656383002/#ps40001
(title: "Fix comments")

[commit-bot: I haz the power, 2016-02-02 20:11:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1656383002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1656383002/40001

[commit-bot: I haz the power, 2016-02-02 20:59:53]

Description was changed from

==========
NEON optimizations for gray -> RGBA (or BGRA) conversions

Swizzle Bench Runtime
Nexus 6P 0.32x
Nexus 9  0.89x

PNG Decode Time (for test set of gray encoded PNGs)
Nexus 6P 0.88x
Nexus 9  0.91x

BUG=skia:4767
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
NEON optimizations for gray -> RGBA (or BGRA) conversions

Swizzle Bench Runtime
Nexus 6P 0.32x
Nexus 9  0.89x

PNG Decode Time (for test set of gray encoded PNGs)
Nexus 6P 0.88x
Nexus 9  0.91x

BUG=skia:4767
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed:
https://skia.googlesource.com/skia/+/2eff71c9b5f984b58961e5a6b4e66774c4385224
==========

[commit-bot: I haz the power, 2016-02-02 20:59:54]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/2eff71c9b5f984b58961e5a6b4e66774c4385224