Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1663303002: Fix bugs in SkBmpCodec (Closed)

Created:
4 years, 10 months ago by msarett
Modified:
4 years, 10 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix bugs in SkBmpCodec The decode should not depend on the requested alpha type. These were exposed by: https://codereview.chromium.org/1641273003 This should cause the number of untriaged images in Gold to go to zero. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1663303002 Committed: https://skia.googlesource.com/skia/+/ebf440816bbb6fccbfb5ab81145c38d32f056b15

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -53 lines) Patch
M src/codec/SkBmpStandardCodec.cpp View 3 chunks +7 lines, -17 lines 0 comments Download
M src/codec/SkMaskSwizzler.cpp View 3 chunks +39 lines, -36 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (5 generated)
msarett
4 years, 10 months ago (2016-02-03 20:39:57 UTC) #3
scroggo
lgtm
4 years, 10 months ago (2016-02-03 20:42:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1663303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1663303002/20001
4 years, 10 months ago (2016-02-03 20:45:50 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 21:12:41 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://skia.googlesource.com/skia/+/ebf440816bbb6fccbfb5ab81145c38d32f056b15

Powered by Google App Engine
This is Rietveld 408576698