Test unpremul decodes

Test unpremul decodes

This is a workaround until SkCanvas supports drawing kUnpremul sources.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1661913005

Committed: https://skia.googlesource.com/skia/+/9e9444cad8a9df626eff49ea271ebb4e3a603a20

[msarett, 2016-02-03 20:00:08]

Description was changed from

==========
Test unpremul decodes

This is a workaround until SkCanvas supports drawing kUnpremul sources.

BUG=skia:
==========

to

==========
Test unpremul decodes

This is a workaround until SkCanvas supports drawing kUnpremul sources.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-02-03 20:06:36]

msarett@google.com changed reviewers:
+ mtklein@google.com, scroggo@google.com

[msarett, 2016-02-03 20:06:36]

Given that a lot of the premul vs unpremul Swizzler code is beginning to
diverge, I think this is important.

https://codereview.chromium.org/1661913005/diff/1/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1661913005/diff/1/dm/DM.cpp#newcode377
dm/DM.cpp:377: alphaModes.push_back(kUnpremul_SkAlphaType);
If we feel that this is too much, I'd be fine with only testing in some codec
modes or scales.

But obviously this gives us the best coverage.

https://codereview.chromium.org/1661913005/diff/1/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/1661913005/diff/1/dm/DMSrcSink.cpp#newcode268
dm/DMSrcSink.cpp:268: SkOpts::RGBA_to_rgbA(row, row, bitmap.width());
I feel comfortable with this, but you could argue that using SkOpts functions to
test other SkOpts functions is a bad idea.

The alternative is to use SkPremultiplyInline pixel by pixel.

[scroggo, 2016-02-03 20:10:01]

lgtm

[msarett, 2016-02-03 20:12:04]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2016-02-03 20:12:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1661913005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1661913005/1

[commit-bot: I haz the power, 2016-02-03 20:39:13]

Description was changed from

==========
Test unpremul decodes

This is a workaround until SkCanvas supports drawing kUnpremul sources.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Test unpremul decodes

This is a workaround until SkCanvas supports drawing kUnpremul sources.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/9e9444cad8a9df626eff49ea271ebb4e3a603a20
==========

[commit-bot: I haz the power, 2016-02-03 20:39:14]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9e9444cad8a9df626eff49ea271ebb4e3a603a20