Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1638463002: Fix leak of SkImageGenerator (Closed)

Created:
4 years, 11 months ago by msarett
Modified:
4 years, 11 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M dm/DMSrcSink.cpp View 2 chunks +2 lines, -2 lines 1 comment Download

Depends on Patchset:

Issue 1188223002 Patch 80001

Messages

Total messages: 9 (4 generated)
msarett
4 years, 11 months ago (2016-01-25 18:24:34 UTC) #3
djsollen
https://codereview.chromium.org/1638463002/diff/1/dm/DMSrcSink.cpp File dm/DMSrcSink.cpp (right): https://codereview.chromium.org/1638463002/diff/1/dm/DMSrcSink.cpp#newcode296 dm/DMSrcSink.cpp:296: SkAutoTDelete<SkImage> image(SkImage::NewFromGenerator(gen.detach(), nullptr)); why do you need to detach ...
4 years, 11 months ago (2016-01-25 18:34:08 UTC) #4
djsollen
lgtm. I read the docs on SkImage.
4 years, 11 months ago (2016-01-25 18:35:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638463002/1
4 years, 11 months ago (2016-01-25 18:35:39 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 18:51:32 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/01813e880a32920e17057ce2b4784f10382ff4f0

Powered by Google App Engine
This is Rietveld 408576698