Use fActualProc to choose fFastProc or fSlowProc in SkSwizzler

Use fActualProc to choose fFastProc or fSlowProc in SkSwizzler

(1) We will now (correctly) choose fFastProc if the client
    calls setSampleX(1).
(2) The logic to choose between fFastProc and fSlowProc
    is now performed once, rather than every time we call
    swizzle().
(3) This will be easier to extend when we add
    fFastSampleProcs for different sample sizes.

This comes from Leon's suggestion in:
https://codereview.chromium.org/1582083005

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1616753003

Committed: https://skia.googlesource.com/skia/+/19032f72165f5c6eab5c2149dae98905f41e3943

[msarett, 2016-01-21 16:41:13]

Description was changed from

==========
Use fActualProc to choose fFastProc or fSlowProc in SkSwizzler

(1) We will now (correctly) choose fFastProc if the client
    calls setSampleX(1).
(2) The logic to choose between fFastProc and fSlowProc
    is now performed once, rather than every time we call
    swizzle().
(3) This will be easier to extend when we add
    fFastSampleProcs for different sample sizes.

This comes from Leon's suggestion in:
https://codereview.chromium.org/1582083005

BUG=skia:
==========

to

==========
Use fActualProc to choose fFastProc or fSlowProc in SkSwizzler

(1) We will now (correctly) choose fFastProc if the client
    calls setSampleX(1).
(2) The logic to choose between fFastProc and fSlowProc
    is now performed once, rather than every time we call
    swizzle().
(3) This will be easier to extend when we add
    fFastSampleProcs for different sample sizes.

This comes from Leon's suggestion in:
https://codereview.chromium.org/1582083005

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-01-21 16:46:08]

msarett@google.com changed reviewers:
+ scroggo@google.com

[scroggo, 2016-01-21 17:24:59]

lgtm

https://codereview.chromium.org/1616753003/diff/1/src/codec/SkSwizzler.cpp
File src/codec/SkSwizzler.cpp (right):

https://codereview.chromium.org/1616753003/diff/1/src/codec/SkSwizzler.cpp#ne...
src/codec/SkSwizzler.cpp:798: if (1 == fSampleX) {
You could simplify this a little to say:

if (1 == fSampleX && fFastProc) {
    fActualProc = fFastProc;
} else {
    fActualProc = fSlowProc;
}

[msarett, 2016-01-21 17:45:33]

https://codereview.chromium.org/1616753003/diff/1/src/codec/SkSwizzler.cpp
File src/codec/SkSwizzler.cpp (right):

https://codereview.chromium.org/1616753003/diff/1/src/codec/SkSwizzler.cpp#ne...
src/codec/SkSwizzler.cpp:798: if (1 == fSampleX) {
On 2016/01/21 17:24:59, scroggo wrote:
> You could simplify this a little to say:
> 
> if (1 == fSampleX && fFastProc) {
>     fActualProc = fFastProc;
> } else {
>     fActualProc = fSlowProc;
> }

Done.

[msarett, 2016-01-21 17:46:11]

The CQ bit was checked by msarett@google.com

[msarett, 2016-01-21 17:46:11]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com
Link to the patchset: https://codereview.chromium.org/1616753003/#ps20001
(title: "Response to comment")

[commit-bot: I haz the power, 2016-01-21 17:46:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1616753003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1616753003/20001

[commit-bot: I haz the power, 2016-01-21 17:59:40]

Description was changed from

==========
Use fActualProc to choose fFastProc or fSlowProc in SkSwizzler

(1) We will now (correctly) choose fFastProc if the client
    calls setSampleX(1).
(2) The logic to choose between fFastProc and fSlowProc
    is now performed once, rather than every time we call
    swizzle().
(3) This will be easier to extend when we add
    fFastSampleProcs for different sample sizes.

This comes from Leon's suggestion in:
https://codereview.chromium.org/1582083005

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Use fActualProc to choose fFastProc or fSlowProc in SkSwizzler

(1) We will now (correctly) choose fFastProc if the client
    calls setSampleX(1).
(2) The logic to choose between fFastProc and fSlowProc
    is now performed once, rather than every time we call
    swizzle().
(3) This will be easier to extend when we add
    fFastSampleProcs for different sample sizes.

This comes from Leon's suggestion in:
https://codereview.chromium.org/1582083005

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/19032f72165f5c6eab5c2149dae98905f41e3943
==========

[commit-bot: I haz the power, 2016-01-21 17:59:40]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/19032f72165f5c6eab5c2149dae98905f41e3943