Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1666853002: SSE optimizations for GrayAlpha -> RGBA/BGRA Premul/Unpremul (Closed)

Created:
4 years, 10 months ago by msarett
Modified:
4 years, 10 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SSE optimizations for GrayAlpha -> RGBA/BGRA Premul/Unpremul Swizzle Runtime (Dell Venue 8) Unpremul 0.17x Premul 0.20x PNG Decode Runtime on GrayAlpha Encoded PNGs (Dell Venue 8) Unpremul Regular 0.91x Unpremul ZeroInit 0.92x Premul Regular 0.84x Premul ZeroInit 0.85x BUG=skia:4767 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1666853002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/095742419d0277a4fb0d499a05ff29b7506f1c5e

Patch Set 1 #

Total comments: 5

Patch Set 2 : Response to comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -8 lines) Patch
M bench/SwizzleBench.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/opts/SkSwizzler_opts.h View 1 3 chunks +59 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
msarett
https://codereview.chromium.org/1666853002/diff/1/src/opts/SkSwizzler_opts.h File src/opts/SkSwizzler_opts.h (right): https://codereview.chromium.org/1666853002/diff/1/src/opts/SkSwizzler_opts.h#newcode583 src/opts/SkSwizzler_opts.h:583: static void grayA_to_RGBA(uint32_t dst[], const void* vsrc, int count) ...
4 years, 10 months ago (2016-02-03 22:23:35 UTC) #3
mtklein
lgtm https://codereview.chromium.org/1666853002/diff/1/src/opts/SkSwizzler_opts.h File src/opts/SkSwizzler_opts.h (right): https://codereview.chromium.org/1666853002/diff/1/src/opts/SkSwizzler_opts.h#newcode590 src/opts/SkSwizzler_opts.h:590: __m128i gg = _mm_or_si128(_mm_and_si128(ga, mask), _mm_slli_epi16(ga, 8)); Might ...
4 years, 10 months ago (2016-02-03 22:46:32 UTC) #4
msarett
https://codereview.chromium.org/1666853002/diff/1/src/opts/SkSwizzler_opts.h File src/opts/SkSwizzler_opts.h (right): https://codereview.chromium.org/1666853002/diff/1/src/opts/SkSwizzler_opts.h#newcode590 src/opts/SkSwizzler_opts.h:590: __m128i gg = _mm_or_si128(_mm_and_si128(ga, mask), _mm_slli_epi16(ga, 8)); On 2016/02/03 ...
4 years, 10 months ago (2016-02-03 22:59:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666853002/20001
4 years, 10 months ago (2016-02-03 23:00:02 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 23:28:40 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/095742419d0277a4fb0d499a05ff29b7506f1c5e

Powered by Google App Engine
This is Rietveld 408576698