Check user gesture before firing an intent in WebView

Check user gesture before firing an intent in WebView

Only fire intents when navigation is initiated by the user
(via a gesture), or by the server (a redirect). This curbs
down attempts to launch intents purely by JS code, which
lead to a poor UX -- tasks appearing from nowhere.

BUG=501633
Committed: https://crrev.com/849952a42e20bbc4ebd3d2805b085982b3f42730
Cr-Commit-Position: refs/heads/master@{#338133}

[mnaganov (inactive), 2015-07-08 23:27:03]

mnaganov@chromium.org changed reviewers:
+ sgurun@chromium.org

[sgurun-gerrit only, 2015-07-09 01:48:52]

On 2015/07/08 23:27:04, mnaganov wrote:

lgtm

[sgurun-gerrit only, 2015-07-09 01:50:57]

The CQ bit was checked by sgurun@chromium.org

[commit-bot: I haz the power, 2015-07-09 01:52:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1180223004/40001

[commit-bot: I haz the power, 2015-07-09 02:01:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-09 02:01:34]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mnaganov (inactive), 2015-07-09 16:53:12]

mnaganov@chromium.org changed reviewers:
+ palmer@chromium.org

[mnaganov (inactive), 2015-07-09 16:53:13]

Hi Chris, can you please take a look at the change in
android_webview/common/render_view_messages.h?

[palmer, 2015-07-09 20:21:59]

LGTM, with a question about documentation.

https://codereview.chromium.org/1180223004/diff/40001/android_webview/common/...
File android_webview/common/render_view_messages.h (right):

https://codereview.chromium.org/1180223004/diff/40001/android_webview/common/...
android_webview/common/render_view_messages.h:103: // when creating a popup
window, and not sent for application initiated
Unless I'm not understanding something, I don't see a special case in
|AwContentRendererClient::HandleNavigation| for pop-up navigations. Is this
comment still accurate?

[mnaganov (inactive), 2015-07-09 20:35:23]

Thanks, Chris!

https://codereview.chromium.org/1180223004/diff/40001/android_webview/common/...
File android_webview/common/render_view_messages.h (right):

https://codereview.chromium.org/1180223004/diff/40001/android_webview/common/...
android_webview/common/render_view_messages.h:103: // when creating a popup
window, and not sent for application initiated
On 2015/07/09 20:21:59, palmer wrote:
> Unless I'm not understanding something, I don't see a special case in
> |AwContentRendererClient::HandleNavigation| for pop-up navigations. Is this
> comment still accurate?

The comment says that this message *isn't sent* for pop-up navigations, that's
why there is no pop-up case in AwContentRendererClient::HandleNavigation :)

Sending ShouldOverrideUrlLoading for popups is handled here:
https://code.google.com/p/chromium/codesearch#chromium/src/android_webview/ja...

In fact, we will be removing this message completely pretty much soon, see
https://codereview.chromium.org/1155713005/, but that patch may be delayed until
after the next branch point, that's why I have to make this change now.

[mnaganov (inactive), 2015-07-09 20:35:30]

The CQ bit was checked by mnaganov@chromium.org

[commit-bot: I haz the power, 2015-07-09 20:37:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1180223004/40001

[commit-bot: I haz the power, 2015-07-09 20:45:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-09 20:47:12]

Patchset 3 (id:??) landed as
https://crrev.com/849952a42e20bbc4ebd3d2805b085982b3f42730
Cr-Commit-Position: refs/heads/master@{#338133}