Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2359)

Unified Diff: android_webview/renderer/aw_content_renderer_client.cc

Issue 1180223004: Check user gesture before firing an intent in WebView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed failing test, added another Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/renderer/aw_content_renderer_client.cc
diff --git a/android_webview/renderer/aw_content_renderer_client.cc b/android_webview/renderer/aw_content_renderer_client.cc
index ea4b0bd3b628757f69886d3a78e4e2945b9b603f..b9c6a3d2e9a9b13d93a37a7fad03074c1c9b5253 100644
--- a/android_webview/renderer/aw_content_renderer_client.cc
+++ b/android_webview/renderer/aw_content_renderer_client.cc
@@ -112,10 +112,11 @@ bool AwContentRendererClient::HandleNavigation(
bool ignore_navigation = false;
base::string16 url = request.url().string();
+ bool has_user_gesture = request.hasUserGesture();
int render_frame_id = render_frame->GetRoutingID();
RenderThread::Get()->Send(new AwViewHostMsg_ShouldOverrideUrlLoading(
- render_frame_id, url, &ignore_navigation));
+ render_frame_id, url, has_user_gesture, is_redirect, &ignore_navigation));
return ignore_navigation;
}

Powered by Google App Engine
This is Rietveld 408576698