android_webview/java/src/org/chromium/android_webview/AwContents.java - Issue 1180223004: Check user gesture before firing an intent in WebView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 1180223004: Check user gesture before firing an intent in WebView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed failing test, added another Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/common/render_view_messages.h ('K') | « android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java ('k') | android_webview/java/src/org/chromium/android_webview/AwContentsClient.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwContents.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java

index 1e30c192c26880425ac68970b29780f29cd3a9ac..76a9cc8ce54d67b7541cfb96b3e60ef6427c4c53 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContents.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java

@@ -484,7 +484,10 @@ public class AwContents implements SmartClipProvider,

// load, redirect and backforward should also be filtered out.

if (!navigationParams.isPost) {

if (!mContentsClient.hasWebViewClient()) {

- ignoreNavigation = AwContentsClient.sendBrowsingIntent(mContext, url);

+ ignoreNavigation = AwContentsClient.sendBrowsingIntent(mContext, url,

+ navigationParams.hasUserGesture

+ || navigationParams.hasUserGestureCarryover,

+ navigationParams.isRedirect);

} else {

ignoreNavigation = mContentsClient.shouldOverrideUrlLoading(url);

}