Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Unified Diff: android_webview/browser/aw_contents_client_bridge_base.h

Issue 1180223004: Check user gesture before firing an intent in WebView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed failing test, added another Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_contents_client_bridge_base.h
diff --git a/android_webview/browser/aw_contents_client_bridge_base.h b/android_webview/browser/aw_contents_client_bridge_base.h
index 265004eb2ad48ea692a8756f56bb647e53e697ed..31c965fae9190e670bc251a26a62e9cd2967f627 100644
--- a/android_webview/browser/aw_contents_client_bridge_base.h
+++ b/android_webview/browser/aw_contents_client_bridge_base.h
@@ -63,7 +63,9 @@ class AwContentsClientBridgeBase {
const content::JavaScriptDialogManager::DialogClosedCallback& callback)
= 0;
- virtual bool ShouldOverrideUrlLoading(const base::string16& url) = 0;
+ virtual bool ShouldOverrideUrlLoading(const base::string16& url,
+ bool has_user_gesture,
+ bool is_redirect) = 0;
};
} // namespace android_webview

Powered by Google App Engine
This is Rietveld 408576698