android_webview/native/aw_contents_client_bridge.h - Issue 1180223004: Check user gesture before firing an intent in WebView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_contents_client_bridge.h

Issue 1180223004: Check user gesture before firing an intent in WebView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed failing test, added another Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/common/render_view_messages.h ('K') | « android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java ('k') | android_webview/native/aw_contents_client_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/native/aw_contents_client_bridge.h

diff --git a/android_webview/native/aw_contents_client_bridge.h b/android_webview/native/aw_contents_client_bridge.h

index a2bde4b02899f4789b7b6bec2db92b5a54ef26d9..0595ba0d864980d58dc7826e3016b0327b6bd83b 100644

--- a/android_webview/native/aw_contents_client_bridge.h

+++ b/android_webview/native/aw_contents_client_bridge.h

@@ -54,7 +54,9 @@ class AwContentsClientBridge : public AwContentsClientBridgeBase {

const base::string16& message_text,

const content::JavaScriptDialogManager::DialogClosedCallback& callback)

override;

- bool ShouldOverrideUrlLoading(const base::string16& url) override;

+ bool ShouldOverrideUrlLoading(const base::string16& url,

+ bool has_user_gesture,

+ bool is_redirect) override;

// Methods called from Java.

void ProceedSslError(JNIEnv* env, jobject obj, jboolean proceed, jint id);