android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java - Issue 1180223004: Check user gesture before firing an intent in WebView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

Issue 1180223004: Check user gesture before firing an intent in WebView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed failing test, added another Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/common/render_view_messages.h ('K') | « android_webview/java/src/org/chromium/android_webview/AwContentsClient.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java b/android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

index 4e2aaeafa38ff93fa9947828aec4163f5fc15b47..712c8013c32b0c286c6c9e5841f822cb9a4d38ca 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

@@ -260,11 +260,12 @@ public class AwContentsClientBridge {

}

@CalledByNative

- private boolean shouldOverrideUrlLoading(String url) {

+ private boolean shouldOverrideUrlLoading(String url, boolean hasUserGesture,

+ boolean isRedirect) {

if (mClient.hasWebViewClient()) {

return mClient.shouldOverrideUrlLoading(url);

} else {

- return AwContentsClient.sendBrowsingIntent(mContext, url);

+ return AwContentsClient.sendBrowsingIntent(mContext, url, hasUserGesture, isRedirect);

}