Check user gesture before firing an intent in WebView

android_webview/common/render_view_messages.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included file, no traditional include guard.
 #include "android_webview/common/aw_hit_test_data.h"
 #include "content/public/common/common_param_traits.h"
 #include "ipc/ipc_channel_handle.h"
 #include "ipc/ipc_message_macros.h"
 #include "ipc/ipc_platform_file.h"
@@ skipping 82 matching lines @@
 // Sent whenever the page scale factor (as seen by RenderView) is changed.
 IPC_MESSAGE_ROUTED1(AwViewHostMsg_PageScaleFactorChanged,
                     float /* page_scale_factor */)
 
 // Sent whenever the contents size (as seen by RenderView) is changed.
 IPC_MESSAGE_ROUTED1(AwViewHostMsg_OnContentsSizeChanged,
                     gfx::Size /* contents_size */)
 
 // Sent immediately before a top level navigation is initiated within Blink.
 // There are some exlusions, the most important ones are it is not sent
 // when creating a popup window, and not sent for application initiated

[palmer, 2015/07/09 20:21:59]

Unless I'm not understanding something, I don't see a special case in
|AwContentRendererClient::HandleNavigation| for pop-up navigations. Is this
comment still accurate?

[mnaganov (inactive), 2015/07/09 20:35:23]

The comment says that this message *isn't sent* for pop-up navigations, that's
why there is no pop-up case in AwContentRendererClient::HandleNavigation :)

Sending ShouldOverrideUrlLoading for popups is handled here:
https://code.google.com/p/chromium/codesearch#chromium/src/android_webview/ja...

In fact, we will be removing this message completely pretty much soon, see
https://codereview.chromium.org/1155713005/, but that patch may be delayed until
after the next branch point, that's why I have to make this change now.

 // navigations. See AwContentRendererClient::HandleNavigation for all
 // cornercases. This is sent before updating the NavigationController state
 // or creating a URLRequest for the main frame resource.
-IPC_SYNC_MESSAGE_CONTROL2_1(AwViewHostMsg_ShouldOverrideUrlLoading,
+IPC_SYNC_MESSAGE_CONTROL4_1(AwViewHostMsg_ShouldOverrideUrlLoading,
                             int /* render_frame_id id */,
                             base::string16 /* in - url */,
+                            bool /* in - has_user_gesture */,
+                            bool /* in - is_redirect */,
                             bool /* out - result */)
 
 // Sent when a subframe is created.
 IPC_MESSAGE_CONTROL2(AwViewHostMsg_SubFrameCreated,
                      int /* parent_render_frame_id */,
                      int /* child_render_frame_id */)