Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 1172183002: Move StartsWith[ASCII] to base namespace. (Closed)

Created:
5 years, 6 months ago by brettw
Modified:
5 years, 6 months ago
Reviewers:
andrewhayden, sky
CC:
chromium-reviews, sadrul, shishir+watch_chromium.org, johnme+watch_chromium.org, nasko+codewatch_chromium.org, jln+watch_chromium.org, ben+mojo_chromium.org, tim+watch_chromium.org, melevin+watch_chromium.org, pvalenzuela+watch_chromium.org, kalyank, mlamouri+watch-content_chromium.org, derat+watch_chromium.org, tdresser+watch_chromium.org, media-router+watch_chromium.org, pam+watch_chromium.org, maniscalco+watch_chromium.org, plundblad+watch_chromium.org, hashimoto+watch_chromium.org, tfarina, avayvod+watch_chromium.org, mvanouwerkerk+watch_chromium.org, plaree+watch_chromium.org, estade+watch_chromium.org, wjia+watch_chromium.org, mmenke, pfeldman, asanka, vandebo (ex-Chrome), donnd+watch_chromium.org, viettrungluu+watch_chromium.org, tburkard+watch_chromium.org, shuchen+watch_chromium.org, vabr+watchlist_chromium.org, noyau+watch_chromium.org, kinuko+watch, tapted, Matt Giuca, Aaron Boodman, benjhayden+dwatch_chromium.org, samuong+watch_chromium.org, jam, chromium-apps-reviews_chromium.org, tnakamura+watch_chromium.org, android-webview-reviews_chromium.org, creis+watch_chromium.org, jsbell+serviceworker_chromium.org, penghuang+watch_chromium.org, nhiroki, rickyz+watch_chromium.org, asvitkine+watch_chromium.org, Jered, mkwst+watchlist-passwords_chromium.org, gavinp+prer_chromium.org, Lei Zhang, serviceworker-reviews, yurys, jshin+watch_chromium.org, dtseng+watch_chromium.org, kmadhusu+watch_chromium.org, peter+watch_chromium.org, David Black, yusukes+watch_chromium.org, zea+watch_chromium.org, dhollowa+watch_chromium.org, jdduke+watch_chromium.org, browser-components-watch_chromium.org, yzshen+watch_chromium.org, rginda+watch_chromium.org, dmazzoni+watch_chromium.org, tracing+reviews_chromium.org, mlamouri+watch-media_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, nona+watch_chromium.org, dzhioev+watch_chromium.org, abarth-chromium, je_julie, darin-cc_chromium.org, devtools-reviews_chromium.org, erikwright+watch_chromium.org, dougw+watch_chromium.org, pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, jfweitz+watch_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, davidben+watch_chromium.org, wfh+watch_chromium.org, maxbogue+watch_chromium.org, phoglund+watch_chromium.org, tommycli, Greg Billock, Paweł Hajdan Jr., James Su, kinuko+fileapi, davemoore+watch_chromium.org, skanuj+watch_chromium.org, felt, qsr+mojo_chromium.org, tzik, posciak+watch_chromium.org, markusheintz_, stevenjb+watch_chromium.org, cbentzel+watch_chromium.org, aboxhall+watch_chromium.org, grt+watch_chromium.org, chromoting-reviews_chromium.org, ozone-reviews_chromium.org, samarth+watch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, horo+watch_chromium.org, gcasto+watchlist_chromium.org, rouslan+autofillwatch_chromium.org, michaeln, nektar+watch_chromium.org, mcasas+watch_chromium.org, kinuko+serviceworker, mkwst+moarreviews-renderer_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@string_util3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move StartsWith[ASCII] to base namespace. NOPRESUBMIT=true (no presubmit due to removing base:: from a ScopedAllowIO) Committed: https://crrev.com/44ce0ec5b05184c4e33d597d4e5a32d9f38b15c2 Cr-Commit-Position: refs/heads/master@{#334108}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : merge #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : merger #

Unified diffs Side-by-side diffs Delta from patch set Stats (+691 lines, -670 lines) Patch
M android_webview/native/android_protocol_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/native/aw_media_url_interceptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/lock_state_controller.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M base/strings/string_util.h View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
M base/strings/string_util.cc View 2 chunks +8 lines, -13 lines 0 comments Download
M base/test/test_pending_task_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/win/win_util.cc View 13 chunks +27 lines, -29 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/preferences/website_preference_bridge.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/autocomplete/builtin_provider.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_backend.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/autocomplete/url_index_private_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/chromeos_utils.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_util.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/file_tasks.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/variations_service_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/power/peripheral_battery_observer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/proxy_cros_settings_parser.cc View 3 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/settings/cros_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system_logs/touch_log_source_ozone.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/cld_component_installer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/enumerate_modules_model_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_actions.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_log.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/commands/command_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_action_api.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/feedback_private/feedback_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_apitest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/blob_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_url_request_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_apitest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui_browsertest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_management.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_protocols_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_web_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/isolated_app_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/google/google_brand.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/local_discovery/device_description.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/router/media_source_helper.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/media/webrtc_browsertest_base.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/webrtc_browsertest_common.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_system_backend.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/native_media_file_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/media_galleries/media_folder_finder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/net/async_dns_field_trial.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/safe_search_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager_browsertest.cc View 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_prefs_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/predictors/autocomplete_action_predictor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/predictors/autocomplete_action_predictor_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/prefetch/prefetch_field_trial.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/tracked/pref_hash_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/prerender/prerender_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profile_resetter/automatic_profile_resetter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/push_messaging/push_messaging_app_identifier.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/protocol_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/local_ntp_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/experimental/supervised_user_async_url_checker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_settings_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_settings_service_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_url_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc View 4 chunks +10 lines, -12 lines 0 comments Download
M chrome/browser/sync/test/integration/extensions_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc View 5 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_db_migration_util.cc View 1 chunk +14 lines, -12 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_db_migration_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_syncable_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/search_controller_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/instant_extended_manual_interactive_uitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/devtools_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/interstitials/interstitial_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_ui.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/favicon_webui_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/common/crash_keys.cc View 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/common/extensions/chrome_extensions_client.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_homepage_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/common/pref_names_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/variations/experiment_labels.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/gcapi/gcapi.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/installer/gcapi/gcapi_omaha_experiment.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/delete_after_reboot_helper.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/installer/util/install_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/shell_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/content_settings_observer.cc View 2 chunks +12 lines, -10 lines 0 comments Download
M chrome/renderer/extensions/app_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/extension_localization_peer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/webstore_bindings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/page_load_histograms.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M chrome/renderer/searchbox/searchbox_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_connector.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/web_view_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/performance_logger.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/chromedriver/server/http_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/profile_reset/jtl_compiler_unittest.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M chrome/tools/profile_reset/jtl_parser_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/importer/bookmark_html_reader.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/utility/media_galleries/media_metadata_parser.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/utility/media_galleries/picasa_album_table_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/bluetooth_gatt_characteristic_service_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/dbus/bluetooth_gatt_descriptor_service_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_gatt_characteristic_service_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_gatt_descriptor_service_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/dbus/fake_shill_service_client.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M chromeos/dbus/session_manager_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/disks/disk_mount_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chromeos/settings/cros_settings_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/system/version_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/service_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/service_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/browser/wallet/wallet_service_url.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.cc View 6 7 8 2 chunks +5 lines, -5 lines 0 comments Download
M components/autofill/content/renderer/password_form_conversion_utils.cc View 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_download_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/autofill/core/browser/form_structure.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/bookmarks/browser/bookmark_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_watcher/exit_code_watcher_win_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/content_settings/core/common/content_settings_pattern_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/test/native_test_server.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/favicon/core/favicon_driver_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/gcm_driver/registration_info.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/google/core/browser/google_url_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/google/core/browser/google_util.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M components/history/core/browser/history_database.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/web_mime_registry_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/web_url_loader_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/invalidation/gcm_network_channel_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mime_util/mime_util.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/nacl/renderer/ppb_nacl_private_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/answers_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/base_search_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/search_suggestion_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/suggestion_answer.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M components/omnibox/url_prefix.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/pairing/bluetooth_controller_pairing_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/password_manager/core/browser/affiliation_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_autofill_manager.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/policy/core/common/preg_parser_win.cc View 3 chunks +10 lines, -7 lines 0 comments Download
M components/proximity_auth/cryptauth/fake_secure_message_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/search_engines/template_url_service_util_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/storage_monitor/portable_device_watcher_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/suggestions/suggestions_service.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/translate/core/browser/translate_language_list.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/translate/core/browser/translate_prefs.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/translate/core/language_detection/language_detection_util.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/url_fixer/url_fixer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/user_manager/user_image/default_user_images.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/variations/net/variations_http_header_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/dump_accessibility_browsertest_base.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/download/download_stats.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/fileapi/fileapi_message_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gamepad/gamepad_platform_data_fetcher_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/media/capture/web_contents_capture_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_database.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/session_history_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tracing/tracing_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/webui/shared_resources_data_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/blink_platform_impl.cc View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/multipart_response_delegate.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/plugin_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/simple_webmimeregistry_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/appcache_interfaces.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/plugin_list_mac.mm View 2 chunks +5 lines, -4 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/test_launcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/savable_resources.cc View 1 chunk +1 line, -1 line 0 comments Download
M dbus/string_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/cast_channel/logger.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/web_request/web_request_permissions.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_apitest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/warning_set.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/csp_validator.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/common/extension.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/extension_urls.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M extensions/common/permissions/permissions_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/common/shell_content_client_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/utility/unpacker_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M google_apis/drive/test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/fake_gaia.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gcm/engine/gcm_store_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_control_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_info_collector_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/config/gpu_test_expectations_parser.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/app/safe_mode_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/experimental_flags.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/net/clients/crn_forwarding_network_client_factory_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/media_codec_bridge.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M media/base/android/media_player_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/key_systems.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/base/mime_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/source_buffer_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/renderers/video_renderer_impl.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M media/video/capture/win/video_capture_device_factory_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/shell_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/mime_util.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M net/base/net_util.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M net/base/net_util_icu.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M net/dns/host_resolver_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/filter/filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/ftp/ftp_directory_listing_parser_netware.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/ftp/ftp_directory_listing_parser_vms.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_auth_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_response_headers.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_stream_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_util.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_bypass_rules.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_config_service_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/server/http_server_unittest.cc View 1 2 5 chunks +6 lines, -7 lines 0 comments Download
M net/ssl/ssl_cipher_suite_names.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/test/embedded_test_server/embedded_test_server.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_in_memory_cache.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M pdf/document_loader.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host.cc View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/protocol/me2me_host_authenticator_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M rlz/lib/rlz_lib.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M rlz/win/lib/machine_deal.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/services/yama_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/blob/blob_url_request_job_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/fileapi/obfuscated_file_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M storage/browser/fileapi/sandbox_directory_database.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M storage/browser/fileapi/sandbox_origin_database.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M testing/generate_gmock_mutant.py View 1 chunk +1 line, -1 line 0 comments Download
M testing/gmock_mutant.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/protobuf/src/google/protobuf/wire_format_unittest.cc View 3 chunks +11 lines, -9 lines 0 comments Download
M third_party/zlib/google/zip_reader.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/Config.h View 1 chunk +2 lines, -1 line 0 comments Download
M tools/gn/filesystem_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/header_checker.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/input_conversion.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/target.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/chromeos/component_extension_ime_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/base/ime/chromeos/extension_ime_util.cc View 2 chunks +22 lines, -24 lines 0 comments Download
M ui/base/l10n/l10n_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/x/x11_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/devices/device_util_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/device/udev/device_manager_udev.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_version_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/oobe/oobe_md_ui.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 37 (19 generated)
brettw
5 years, 6 months ago (2015-06-09 22:55:54 UTC) #2
sky
Rubber stamp LGTM
5 years, 6 months ago (2015-06-09 23:40:36 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172183002/20001
5 years, 6 months ago (2015-06-10 09:20:03 UTC) #5
andrewhayden
On 2015/06/10 09:20:03, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
5 years, 6 months ago (2015-06-10 09:20:58 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/26591) linux_chromium_gn_chromeos_rel on ...
5 years, 6 months ago (2015-06-10 09:29:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172183002/40001
5 years, 6 months ago (2015-06-11 19:23:36 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/81258)
5 years, 6 months ago (2015-06-11 19:43:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172183002/80001
5 years, 6 months ago (2015-06-11 19:50:57 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/62687) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 6 months ago (2015-06-11 20:03:10 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172183002/100001
5 years, 6 months ago (2015-06-11 20:19:16 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/81291)
5 years, 6 months ago (2015-06-11 20:48:06 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172183002/120001
5 years, 6 months ago (2015-06-11 20:48:21 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/46881)
5 years, 6 months ago (2015-06-11 21:19:47 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172183002/140001
5 years, 6 months ago (2015-06-11 21:49:47 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/60925)
5 years, 6 months ago (2015-06-11 22:49:32 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172183002/160001
5 years, 6 months ago (2015-06-11 23:21:16 UTC) #35
commit-bot: I haz the power
Committed patchset #9 (id:160001)
5 years, 6 months ago (2015-06-12 01:58:43 UTC) #36
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 01:59:39 UTC) #37
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/44ce0ec5b05184c4e33d597d4e5a32d9f38b15c2
Cr-Commit-Position: refs/heads/master@{#334108}

Powered by Google App Engine
This is Rietveld 408576698