components/password_manager/core/browser/password_autofill_manager.cc - Issue 1172183002: Move StartsWith[ASCII] to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_autofill_manager.cc

Issue 1172183002: Move StartsWith[ASCII] to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@string_util3

Patch Set: merger Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/affiliation_utils.cc ('k') | components/password_manager/core/browser/password_form_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_autofill_manager.cc

diff --git a/components/password_manager/core/browser/password_autofill_manager.cc b/components/password_manager/core/browser/password_autofill_manager.cc

index d585a4778b187c4dcb378bf35e58cdc45e316c02..a9b6644d8d25ad3f018facdf2255edffb8cd2694 100644

--- a/components/password_manager/core/browser/password_autofill_manager.cc

+++ b/components/password_manager/core/browser/password_autofill_manager.cc

@@ -64,8 +64,8 @@ void GetSuggestions(const autofill::PasswordFormFillData& fill_data,

const base::string16& current_username,

std::vector<autofill::Suggestion>* suggestions,

bool show_all) {

- if (show_all ||

- StartsWith(fill_data.username_field.value, current_username, false)) {

+ if (show_all || base::StartsWith(fill_data.username_field.value,

+ current_username, false)) {

autofill::Suggestion suggestion(

ReplaceEmptyUsername(fill_data.username_field.value));

suggestion.label = GetHumanReadableRealm(fill_data.preferred_realm);

@@ -74,7 +74,7 @@ void GetSuggestions(const autofill::PasswordFormFillData& fill_data,

}

for (const auto& login : fill_data.additional_logins) {

- if (show_all || StartsWith(login.first, current_username, false)) {

+ if (show_all || base::StartsWith(login.first, current_username, false)) {

autofill::Suggestion suggestion(ReplaceEmptyUsername(login.first));

suggestion.label = GetHumanReadableRealm(login.second.realm);

suggestion.frontend_id = autofill::POPUP_ITEM_ID_PASSWORD_ENTRY;

@@ -85,7 +85,7 @@ void GetSuggestions(const autofill::PasswordFormFillData& fill_data,

for (const auto& usernames : fill_data.other_possible_usernames) {

for (size_t i = 0; i < usernames.second.size(); ++i) {

if (show_all ||

- StartsWith(usernames.second[i], current_username, false)) {

+ base::StartsWith(usernames.second[i], current_username, false)) {

autofill::Suggestion suggestion(

ReplaceEmptyUsername(usernames.second[i]));

suggestion.label = GetHumanReadableRealm(usernames.first.realm);