Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: chrome/renderer/extensions/webstore_bindings.cc

Issue 1172183002: Move StartsWith[ASCII] to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@string_util3
Patch Set: merger Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/extensions/webstore_bindings.h" 5 #include "chrome/renderer/extensions/webstore_bindings.h"
6 6
7 #include "base/strings/string_util.h" 7 #include "base/strings/string_util.h"
8 #include "chrome/common/extensions/api/webstore/webstore_api_constants.h" 8 #include "chrome/common/extensions/api/webstore/webstore_api_constants.h"
9 #include "chrome/common/extensions/chrome_extension_messages.h" 9 #include "chrome/common/extensions/chrome_extension_messages.h"
10 #include "components/crx_file/id_util.h" 10 #include "components/crx_file/id_util.h"
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 } 153 }
154 154
155 GURL webstore_url = GURL(webstore_url_string); 155 GURL webstore_url = GURL(webstore_url_string);
156 if (!webstore_url.is_valid()) { 156 if (!webstore_url.is_valid()) {
157 *error = kInvalidWebstoreItemUrlError; 157 *error = kInvalidWebstoreItemUrlError;
158 return false; 158 return false;
159 } 159 }
160 160
161 if (webstore_url.scheme() != webstore_base_url.scheme() || 161 if (webstore_url.scheme() != webstore_base_url.scheme() ||
162 webstore_url.host() != webstore_base_url.host() || 162 webstore_url.host() != webstore_base_url.host() ||
163 !StartsWithASCII( 163 !base::StartsWithASCII(webstore_url.path(), webstore_base_url.path(),
164 webstore_url.path(), webstore_base_url.path(), true)) { 164 true)) {
165 *error = kInvalidWebstoreItemUrlError; 165 *error = kInvalidWebstoreItemUrlError;
166 return false; 166 return false;
167 } 167 }
168 168
169 std::string candidate_webstore_item_id = webstore_url.path().substr( 169 std::string candidate_webstore_item_id = webstore_url.path().substr(
170 webstore_base_url.path().length()); 170 webstore_base_url.path().length());
171 if (!crx_file::id_util::IdIsValid(candidate_webstore_item_id)) { 171 if (!crx_file::id_util::IdIsValid(candidate_webstore_item_id)) {
172 *error = kInvalidWebstoreItemUrlError; 172 *error = kInvalidWebstoreItemUrlError;
173 return false; 173 return false;
174 } 174 }
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
246 v8::Isolate* isolate = context()->isolate(); 246 v8::Isolate* isolate = context()->isolate();
247 v8::HandleScope handle_scope(isolate); 247 v8::HandleScope handle_scope(isolate);
248 v8::Context::Scope context_scope(context()->v8_context()); 248 v8::Context::Scope context_scope(context()->v8_context());
249 v8::Local<v8::Value> argv[] = { 249 v8::Local<v8::Value> argv[] = {
250 v8::Number::New(isolate, percent_downloaded / 100.0)}; 250 v8::Number::New(isolate, percent_downloaded / 100.0)};
251 context()->module_system()->CallModuleMethod( 251 context()->module_system()->CallModuleMethod(
252 "webstore", "onDownloadProgress", arraysize(argv), argv); 252 "webstore", "onDownloadProgress", arraysize(argv), argv);
253 } 253 }
254 254
255 } // namespace extensions 255 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/renderer/extensions/extension_localization_peer.cc ('k') | chrome/renderer/page_load_histograms.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698